Special handling for "single custom" uploads is an abomination

Bug #56747 reported by Malcolm Cleaton
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Invalid
Undecided
Celso Providelo

Bug Description

In various places in the Soyuz code, we have special magic handling for any upload which only contains a single custom file.

This is ridiculous; handling should be on the basis of the types of custom uploads, or on other information about the file (such as who uploaded it, which door to Soyuz it came through, etc., which we don't directly store at the moment).

Depending on the fact that, with current policy, only a certain type of upload has this file count, is a timebomb - what if we change the policy? What if we introduce another new type of custom upload and it doesn't want this special magic handling?

I feel dirty. I'm going to go shower.

Tags: lp-soyuz
Revision history for this message
Celso Providelo (cprov) wrote :

This was fixed by nascentupload-cataclysm.

Changed in soyuz:
assignee: nobody → cprov
status: Unconfirmed → Rejected
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.