Odoo Addons (MOVED TO GITHUB)

Cancelling sale order should affect Procurements,production orders

Bug #588220 reported by David Janssens on 2010-06-01

This bug affects 5 people

Affects		Status	Importance	Assigned to	Milestone
	Odoo Addons (MOVED TO GITHUB)	Fix Released	Medium	OpenERP R&D Addons Team 3

Bug Description

When canceling sale orders after they are confirmed, the created procurements are not canceled (still 'confirmed' for example).

Related branches

lp:~openerp-commiter/openobject-addons/trunk-dev-addons3-mtr1

Merged into lp:~openerp-dev/openobject-addons/trunk-dev-addons3 at revision 4983

OpenERP R&D Team: Pending requested 2011-02-14

lp:~openerp-dev/openobject-addons/trunk-dev-addons3

Merged into lp:openobject-addons at revision 4238

xrg (community): Needs Fixing on 2010-12-30

Diff: 22835 lines (+5012/-2265)

319 files modified

account/account.py (+28/-8)
account/account_analytic_line.py (+0/-2)
account/account_bank_statement.py (+21/-0)
account/account_installer.xml (+1/-1)
account/account_invoice_view.xml (+0/-1)
account/account_move_line.py (+14/-7)
account/account_report.xml (+1/-0)
account/account_view.xml (+12/-18)
account/board_account_view.xml (+1/-0)
account/i18n/account.pot (+13/-1)
account/i18n/ar.po (+13/-1)
account/i18n/bg.po (+14/-2)
account/i18n/br.po (+13/-1)
account/i18n/bs.po (+13/-1)
account/i18n/ca.po (+13/-2)
account/i18n/cs.po (+13/-1)
account/i18n/da.po (+13/-1)
account/i18n/de.po (+13/-2)
account/i18n/el.po (+13/-2)
account/i18n/en_US.po (+12/-0)
account/i18n/es.po (+13/-3)
account/i18n/es_AR.po (+13/-3)
account/i18n/es_EC.po (+14/-2)
account/i18n/et.po (+13/-1)
account/i18n/eu.po (+13/-1)
account/i18n/fa.po (+13/-1)
account/i18n/fi.po (+14/-2)
account/i18n/fr.po (+13/-3)
account/i18n/fr_BE.po (+13/-1)
account/i18n/gl.po (+13/-1)
account/i18n/gu.po (+13/-1)
account/i18n/he.po (+13/-1)
account/i18n/hi.po (+13/-1)
account/i18n/hr.po (+13/-1)
account/i18n/hu.po (+13/-1)
account/i18n/id.po (+13/-1)
account/i18n/it.po (+13/-3)
account/i18n/kab.po (+13/-1)
account/i18n/ko.po (+14/-2)
account/i18n/lt.po (+13/-1)
account/i18n/lv.po (+14/-2)
account/i18n/mn.po (+13/-1)
account/i18n/nb.po (+13/-1)
account/i18n/nl.po (+13/-2)
account/i18n/nl_BE.po (+13/-1)
account/i18n/oc.po (+13/-1)
account/i18n/pl.po (+13/-2)
account/i18n/pt.po (+14/-2)
account/i18n/pt_BR.po (+14/-2)
account/i18n/ro.po (+13/-2)
account/i18n/ru.po (+14/-2)
account/i18n/si.po (+13/-1)
account/i18n/sk.po (+13/-1)
account/i18n/sl.po (+14/-2)
account/i18n/sq.po (+13/-1)
account/i18n/sr.po (+13/-1)
account/i18n/sr@latin.po (+13/-1)
account/i18n/sv.po (+14/-2)
account/i18n/ta.po (+13/-1)
account/i18n/te.po (+13/-1)
account/i18n/th.po (+13/-1)
account/i18n/tlh.po (+13/-1)
account/i18n/tr.po (+14/-2)
account/i18n/ug.po (+13/-1)
account/i18n/uk.po (+13/-1)
account/i18n/vi.po (+13/-1)
account/i18n/zh_CN.po (+14/-2)
account/i18n/zh_HK.po (+13/-1)
account/i18n/zh_TW.po (+14/-2)
account/invoice.py (+19/-11)
account/report/__init__.py (+0/-2)
account/report/account_balance.py (+1/-0)
account/report/account_entries_report.py (+13/-17)
account/report/account_entries_report_view.xml (+3/-3)
account/report/account_general_ledger.py (+3/-1)
account/report/account_invoice_report_view.xml (+1/-0)
account/report/account_voucher_print.py (+0/-69)
account/report/account_voucher_print.rml (+0/-470)
account/res_currency.py (+4/-1)
account/security/ir.model.access.csv (+1/-0)
account/test/account_bank_statement.yml (+2/-2)
account/test/account_cash_statement.yml (+2/-2)
account/test/account_customer_invoice.yml (+1/-1)
account/test/account_period_close.yml (+4/-4)
account/test/account_report.yml (+6/-14)
account/test/account_validate_account_move.yml (+6/-6)
account/test/chart_of_account.yml (+2/-2)
account/wizard/account_open_closed_fiscalyear.py (+1/-1)
account/wizard/account_tax_chart_view.xml (+1/-1)
account_budget/account_budget.py (+1/-1)
account_budget/account_budget_view.xml (+2/-2)
account_budget/test/account_budget.yml (+7/-7)
account_followup/report/account_followup_report.py (+1/-2)
account_followup/test/account_followup.yml (+3/-2)
account_followup/wizard/account_followup_print.py (+8/-5)
account_payment/test/account_payment.yml (+2/-2)
account_voucher/account_voucher.py (+7/-3)
account_voucher/security/ir.model.access.csv (+2/-0)
account_voucher/voucher_sales_purchase_view.xml (+2/-2)
auction/test/auction.yml (+6/-6)
auction/test/auction_wizard.yml (+8/-8)
base_calendar/test/base_calendar_test.yml (+6/-6)
crm/test/test_crm_meeting.yml (+5/-3)
crm/test/test_crm_opportunity.yml (+4/-4)
crm/test/test_crm_phonecall.yml (+5/-4)
crm_claim/test/test_crm_claim.yml (+1/-1)
crm_helpdesk/crm_helpdesk_demo.xml (+4/-4)
crm_helpdesk/test/test_crm_helpdesk.yml (+1/-1)
delivery/test/delivery_report.yml (+3/-3)
event/test/test_event.yml (+2/-2)
hr_attendance/test/test_hr_attendance.yml (+2/-2)
hr_contract/test/test_hr_contract.yml (+4/-4)
hr_evaluation/hr_evaluation.py (+1/-1)
hr_evaluation/test/test_hr_evaluation.yml (+2/-2)
hr_expense/hr_expense_demo.xml (+6/-6)
hr_expense/test/test_hr_expense.yml (+2/-2)
hr_holidays/hr_holidays_view.xml (+2/-2)
hr_holidays/test/test_hr_holiday.yml (+4/-4)
hr_payroll/hr_payroll.py (+4/-4)
hr_payroll/hr_payroll_data.xml (+3/-3)
hr_payroll/hr_payroll_demo.xml (+2/-2)
hr_payroll/hr_payroll_view.xml (+0/-2)
hr_payroll/i18n/de.po (+2/-2)
hr_payroll/i18n/es.po (+2/-2)
hr_payroll/i18n/et.po (+2/-2)
hr_payroll/i18n/fr.po (+2/-2)
hr_payroll/i18n/hr.po (+2/-2)
hr_payroll/i18n/hr_payroll.pot (+2/-2)
hr_payroll/i18n/hu.po (+2/-2)
hr_payroll/i18n/it.po (+2/-2)
hr_payroll/i18n/mn.po (+2/-2)
hr_payroll/i18n/nl.po (+2/-2)
hr_payroll/i18n/pl.po (+2/-2)
hr_payroll/i18n/pt.po (+2/-2)
hr_payroll/i18n/ru.po (+2/-2)
hr_payroll/i18n/sr@latin.po (+2/-2)
hr_payroll/i18n/sv.po (+2/-2)
hr_payroll/i18n/zh_CN.po (+2/-2)
hr_payroll/test/payment_advice.yml (+2/-2)
hr_payroll/test/payroll_register.yml (+3/-3)
hr_payroll/test/payslip.yml (+2/-2)
hr_recruitment/test/test_hr_recruitment.yml (+3/-3)
hr_timesheet/test/test_hr_timesheet.yml (+5/-4)
hr_timesheet_invoice/report/account_analytic_profit.rml (+1/-1)
hr_timesheet_invoice/test/test_hr_timesheet_invoice.yml (+1/-1)
hr_timesheet_invoice/wizard/hr_timesheet_analytic_profit.py (+1/-1)
hr_timesheet_invoice/wizard/hr_timesheet_analytic_profit_view.xml (+3/-3)
hr_timesheet_sheet/hr_timesheet_sheet.py (+1/-1)
hr_timesheet_sheet/hr_timesheet_sheet_view.xml (+15/-1)
hr_timesheet_sheet/i18n/ar.po (+1/-5)
hr_timesheet_sheet/i18n/bg.po (+1/-5)
hr_timesheet_sheet/i18n/bs.po (+1/-5)
hr_timesheet_sheet/i18n/ca.po (+1/-5)
hr_timesheet_sheet/i18n/cs.po (+1/-5)
hr_timesheet_sheet/i18n/de.po (+1/-5)
hr_timesheet_sheet/i18n/el.po (+1/-5)
hr_timesheet_sheet/i18n/es.po (+1/-5)
hr_timesheet_sheet/i18n/es_AR.po (+1/-5)
hr_timesheet_sheet/i18n/et.po (+1/-5)
hr_timesheet_sheet/i18n/fi.po (+1/-5)
hr_timesheet_sheet/i18n/fr.po (+1/-5)
hr_timesheet_sheet/i18n/hr.po (+1/-5)
hr_timesheet_sheet/i18n/hr_timesheet_sheet.pot (+1/-5)
hr_timesheet_sheet/i18n/hu.po (+1/-5)
hr_timesheet_sheet/i18n/id.po (+1/-5)
hr_timesheet_sheet/i18n/it.po (+1/-5)
hr_timesheet_sheet/i18n/ko.po (+1/-5)
hr_timesheet_sheet/i18n/lt.po (+1/-5)
hr_timesheet_sheet/i18n/lv.po (+1/-5)
hr_timesheet_sheet/i18n/mn.po (+1/-5)
hr_timesheet_sheet/i18n/nl.po (+1/-5)
hr_timesheet_sheet/i18n/nl_BE.po (+1/-7)
hr_timesheet_sheet/i18n/pl.po (+1/-5)
hr_timesheet_sheet/i18n/pt.po (+1/-5)
hr_timesheet_sheet/i18n/pt_BR.po (+1/-5)
hr_timesheet_sheet/i18n/ro.po (+1/-5)
hr_timesheet_sheet/i18n/ru.po (+1/-5)
hr_timesheet_sheet/i18n/sl.po (+1/-5)
hr_timesheet_sheet/i18n/sq.po (+1/-5)
hr_timesheet_sheet/i18n/sv.po (+1/-5)
hr_timesheet_sheet/i18n/tlh.po (+1/-5)
hr_timesheet_sheet/i18n/tr.po (+1/-5)
hr_timesheet_sheet/i18n/uk.po (+1/-5)
hr_timesheet_sheet/i18n/vi.po (+1/-5)
hr_timesheet_sheet/i18n/zh_CN.po (+1/-5)
hr_timesheet_sheet/i18n/zh_TW.po (+1/-5)
hr_timesheet_sheet/security/ir.model.access.csv (+1/-0)
hr_timesheet_sheet/test/test_hr_timesheet_sheet.yml (+8/-8)
idea/test/test_idea.yml (+1/-1)
l10n_br/i18n/de.po (+29/-0)
l10n_br/i18n/en_US.po (+29/-0)
l10n_br/i18n/fr.po (+29/-0)
l10n_br/i18n/l10n_br.pot (+29/-0)
l10n_cn/i18n/de.po (+36/-0)
l10n_cn/i18n/en_US.po (+36/-0)
l10n_cn/i18n/fr.po (+36/-0)
l10n_cn/i18n/l10n_cn.pot (+36/-0)
l10n_cr/i18n/de.po (+159/-0)
l10n_cr/i18n/en_US.po (+159/-0)
l10n_cr/i18n/fr.po (+159/-0)
l10n_cr/i18n/l10n_cr.pot (+159/-0)
l10n_de/account_chart_skr04.xml (+34/-34)
l10n_ec/account_chart.xml (+12/-12)
l10n_ec/i18n/de.po (+35/-0)
l10n_ec/i18n/en_US.po (+35/-0)
l10n_ec/i18n/fr.po (+35/-0)
l10n_ec/i18n/l10n_ec.pot (+35/-0)
l10n_fr/plan_comptable_general_demo.xml (+185/-185)
l10n_in/l10n_in_chart.xml (+1/-1)
l10n_it/data/account.account.template.csv (+233/-233)
l10n_it/i18n/de.po (+155/-0)
l10n_it/i18n/en_US.po (+155/-0)
l10n_it/i18n/fr.po (+155/-0)
l10n_it/i18n/l10n_it.pot (+155/-0)
l10n_mx/account_chart.xml (+1/-1)
l10n_mx/i18n/de.po (+33/-0)
l10n_mx/i18n/en_US.po (+33/-0)
l10n_mx/i18n/fr.po (+33/-0)
l10n_mx/i18n/l10n_mx.pot (+33/-0)
l10n_nl/i18n/de.po (+54/-0)
l10n_nl/i18n/en_US.po (+54/-0)
l10n_nl/i18n/fr.po (+54/-0)
l10n_nl/i18n/l10n_nl.pot (+54/-0)
l10n_pl/account_chart.xml (+1/-1)
l10n_pl/i18n/de.po (+39/-0)
l10n_pl/i18n/en_US.po (+39/-0)
l10n_pl/i18n/fr.po (+39/-0)
l10n_pl/i18n/l10n_pl.pot (+39/-0)
l10n_ro/account_chart.xml (+6/-6)
l10n_ro/i18n/de.po (+48/-0)
l10n_ro/i18n/en_US.po (+48/-0)
l10n_ro/i18n/fr.po (+48/-0)
l10n_ro/i18n/l10n_ro.pot (+48/-0)
l10n_th/account_data.xml (+4/-4)
l10n_th/i18n/de.po (+35/-0)
l10n_th/i18n/en_US.po (+35/-0)
l10n_th/i18n/fr.po (+35/-0)
l10n_th/i18n/l10n_th.pot (+35/-0)
l10n_uk/l10n_uk_chart.xml (+1/-1)
l10n_ve/account_chart.xml (+2/-2)
l10n_ve/i18n/de.po (+39/-0)
l10n_ve/i18n/en_US.po (+39/-0)
l10n_ve/i18n/fr.po (+39/-0)
l10n_ve/i18n/l10n_ve.pot (+39/-0)
lunch/test/test_lunch.yml (+2/-2)
membership/membership_view.xml (+0/-1)
membership/test/test_membership.yml (+22/-22)
mrp/mrp.py (+1/-1)
mrp/test/mrp_phantom_bom.yml (+27/-27)
mrp/test/mrp_procurement.yml (+2/-2)
mrp/test/mrp_production_order.yml (+5/-5)
mrp_jit/test/mrp_jit.yml (+3/-3)
mrp_operations/test/mrp_operations.yml (+13/-13)
mrp_repair/test/test_mrp_repair.yml (+14/-14)
mrp_subproduct/test/mrp_subproduct.yml (+1/-1)
multi_company/multi_company_demo.xml (+4/-0)
point_of_sale/point_of_sale_demo.xml (+15/-15)
point_of_sale/report/pos_sales_user.py (+1/-2)
point_of_sale/report/pos_users_product.py (+2/-2)
point_of_sale/test/point_of_sale_report.yml (+2/-2)
point_of_sale/test/point_of_sale_test.yml (+15/-7)
project/project.py (+1/-1)
project/test/test_project.yml (+7/-7)
project_long_term/test/schedule_phase_tasks.yml (+1/-1)
project_long_term/test/schedule_project_phases.yml (+62/-62)
project_long_term/test/schedule_project_tasks.yml (+1/-1)
project_mrp/test/project_task_procurement.yml (+1/-1)
project_planning/test/planning_states.yml (+2/-2)
project_retro_planning/test/deadline_change.yml (+3/-3)
project_timesheet/test/worktask_entry_to_timesheetline_entry.yml (+31/-31)
purchase/purchase.py (+2/-2)
purchase/purchase_demo.xml (+3/-3)
purchase/test/procurement_buy.yml (+18/-18)
purchase/test/purchase_from_manual.yml (+2/-2)
purchase/test/purchase_from_order.yml (+12/-12)
purchase/test/purchase_from_picking.yml (+4/-3)
purchase_requisition/purchase_requisition_demo.xml (+1/-1)
purchase_requisition/test/purchase_requisition.yml (+39/-39)
purchase_requisition/test/purchase_requisition_exclusive.yml (+24/-24)
resource/resource.py (+1/-1)
sale/test/advance_invoice.yml (+11/-11)
sale/test/invoice_on_ordered_qty.yml (+12/-12)
sale/test/invoice_on_shipped_qty.yml (+13/-12)
sale/test/manual_order_policy.yml (+2/-2)
sale/test/picking_order_policy.yml (+14/-13)
sale/test/postpaid_order_policy.yml (+23/-23)
sale/test/prepaid_order_policy.yml (+11/-11)
sale/test/sale_procurement.yml (+5/-5)
sale/test/so_make_invoice.yml (+3/-3)
sale/test/so_make_line_invoice.yml (+14/-14)
sale_margin/test/sale_margin.yml (+2/-2)
sale_mrp/test/sale_mrp.yml (+4/-4)
stock/stock.py (+2/-2)
stock/test/stock_test.yml (+97/-97)
stock_invoice_directly/test/stock_invoice_directly.yml (+11/-11)
stock_location/test/stock_location_pull_flow.yml (+47/-47)
stock_location/test/stock_location_push_flow.yml (+17/-17)
stock_no_autopicking/test/stock_no_autopicking.yml (+2/-2)
stock_planning/test/stock_planning.yml (+28/-28)
survey/i18n/bg.po (+1/-1)
survey/i18n/cs.po (+1/-1)
survey/i18n/de.po (+1/-1)
survey/i18n/es.po (+1/-1)
survey/i18n/et.po (+1/-1)
survey/i18n/fr.po (+2/-2)
survey/i18n/hr.po (+1/-1)
survey/i18n/mn.po (+1/-1)
survey/i18n/nl.po (+1/-1)
survey/i18n/pl.po (+1/-1)
survey/i18n/pt.po (+1/-1)
survey/i18n/ru.po (+1/-1)
survey/i18n/sl.po (+1/-1)
survey/i18n/sr.po (+1/-1)
survey/i18n/sr@latin.po (+1/-1)
survey/i18n/survey.pot (+1/-1)
survey/i18n/sv.po (+1/-1)
survey/i18n/zh_CN.po (+1/-1)
survey/survey.py (+1/-1)
survey/survey_demo.xml (+34/-34)

Revision history for this message

Vinay Rana (OpenERP) (vra-openerp) wrote on 2010-06-02:

bug-588220-cancelling-sale-order Edit (1.1 KiB, text/plain)

Hello David and Numérigraphe,

Can you please check the attached patch and notify me?

Thanks.

Changed in openobject-addons:
status:	New → In Progress

Jay Vora (Serpent Consulting Services) (jayvora) on 2010-08-05

summary:	- cancelling sale order + Cancelling sale order should affect Procurements,production orders
Changed in openobject-addons:
milestone:	none → 6.0
status:	In Progress → Confirmed

Revision history for this message

Santi Argüeso(Pexego) (santiago-pexego) wrote on 2010-09-09:

I think this minimal patch is not the solution at all.
You can not simply change the state of the procurement. You have to cancel the related movements and picking an trigger the workflow of the procurement NOT change the state.

If your procurement type is make to order, if there are related productions or purchase orders you must cancel them if they are not in progress and the procurement generated form production order have to be cancelled also.

I know this is not easy but i think that is the correct way for working

Moreover, if your procurement is make to stock and it has launched an orderpoint i think it must be undo so you don need those products yet

Vinay Rana (OpenERP) (vra-openerp) on 2010-11-24

Changed in openobject-addons:
assignee:	nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
importance:	Undecided → Medium
milestone:	6.0 → none
status:	Confirmed → Triaged

Revision history for this message

qdp (OpenERP) (qdp) wrote on 2010-11-26:

what we gonna do is: we call the method cancel of the procurement workflow so that if it can cancel it will do it, but we don't write the state (and if it cannot cancel itself then nevermind).

Revision history for this message

Numérigraphe (numerigraphe) wrote on 2010-11-26:

I suppose that's right, but I humbly admit the manufacturing experts are more qualified - I'm subscribing them.
Lionel.

Revision history for this message

Numérigraphe (numerigraphe) wrote on 2010-11-26:

Also, please make sure that a second procurement is not created whenever a canceled order is confirmed again, and the initial procurement couldn't be canceled.
Lionel Sausin.

Revision history for this message

Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote on 2010-11-29:

Hi,

I agree with Quentin (qdp).

Regards,

Joël

Meera Trambadia (OpenERP) (mtr-openerp) on 2010-12-07

Changed in openobject-addons:
status:	Triaged → In Progress

qdp (OpenERP) (qdp) on 2010-12-09

Changed in openobject-addons:
milestone:	none → 6.0-rc2

Revision history for this message

Meera Trambadia (OpenERP) (mtr-openerp) wrote on 2010-12-17:

Hello David Janssens,

Its fixed in https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-dev-addons3 branch.
Revision ID: mra@mra-laptop-20101217114853-kukmk0h8b1yes89c
Revision no: 4731

Thanks
mtr

Changed in openobject-addons:
status:	In Progress → Fix Released

Revision history for this message

Meera Trambadia (OpenERP) (mtr-openerp) wrote on 2010-12-28:

Hello Ferdinand,

I have checked sales manager dashboard - sales by month.
It gives the sale order lines which are in 'manual','progress','done' state which belongs to the current fiscal year.Now the buttons are working in the graph view.

@AMP:I have checked "Sales Analysis" report's no of Lines in Group by months gives the correct values.

Its fixed in https://code.launchpad.net/~openerp-commiter/openobject-addons/trunk-dev-addons3-mtr1 branch.
Revision ID: mtr@mtr-20101228115016-d6sv8evl5b6mbmsh
Revision no: 4665

Thanks
mtr

Revision history for this message

Meera Trambadia (OpenERP) (mtr-openerp) wrote on 2010-12-28:

#8 is for https://bugs.launchpad.net/openobject-addons/+bug/694144, posted here by mistake.

Revision history for this message

Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote on 2011-09-05:

#10

cancel_proc_from_so.patch Edit (1.2 KiB, text/plain)

Dear all,

I just figure out that this bug affect the 5.0 as well, but you didn't back port the fix !!

To reproduce:

1 ) Create an SO with MTO product/Buy
2) Confirm SO
3) Cancel Picking + Cancel SO
4) Run Scheduler

=> The SO is reseted to Shipping Exception... That's not what we want.

We except the SO to cancel the related procurement as you made it for 6.0...

I post the patch => tested in production on my side.

Please apply ASAP to last 5.0 stable.

Regards,

Joël

Changed in openobject-addons:
status:	Fix Released → New

Revision history for this message

Olivier Dony (Odoo) (odo-openerp) wrote on 2011-09-06:

#11

On 09/05/2011 03:43 PM, Joël Grand-Guillaume @ CampToCamp wrote:
> Please apply ASAP to last 5.0 stable.

Hi Joel,

Thanks for the feedback and for testing the original patch on 5.0!

However, it is important to stick to our bug management policy. Let me explain: the current bug management policy (since November 2010) specifies that there is no automatic backport of bugfixes, expect for a few specific cases (High importance bugs and security issues). Backports must be requested and justified via OPW/OpenERP Enterprise channel.
The many reasons for this policy have been explained and can be found in our documentation[1]. The documentation also explains what the different bug Importance values mean[2].

As a result, the bug should be kept Fix Released for now. If a backport is requested via OPW, a new "affects 5.0" will be added by the OPW team and assigned to themselves to reflect this.

Thanks for your understanding and cooperation!

PS: As a member of OpenERP Drivers, it is doubly important for you to be aware of this

[1] http://bit.ly/openerp-bug-policy
[2] http://bit.ly/openerp-bug-process