ORM: search should return empty list when meeting a NULL many2one in the middle of the evaluation of a chained domain expression.

Hi Julien,

From my point of view, no code should pass such a condition to server.

Domain has always to be trustworthy.

We have such a 'insulation' on ir_rule.py's _domain_force_get() method.

Thanks.

The problem comes from this code in bin/osv/expression.py (lines 367-372 in 5.0.11):

            else:
                # the case for [field, 'in', []] or [left, 'not in', []]
                if operator == 'in':
                    query = '(%s.%s IS NULL)' % (table._table, left)
                else:
                    query = '(%s.%s IS NOT NULL)' % (table._table, left)

that should be replaced with:

            elif operator == 'not in':
                query = '(1=1)'

because:
- (field, 'in', []) doesn't mean that field can be NULL
- "field can be NULL" should be written: (field, 'in', [False]) or (field, '=', False)
- related fields returns wrong answer
            ie:
                account.invoice with related field 'picking_state' (picking_id,state)
                account.invoice search like [('picking_state','=','Bob Marley')] will return all invoices having no picking

Please replace part of code

I agree with Frédéric proposal. ('field','in',[]) is broken and has already provoked several grave issues in production databases to us.

Hi Guys,

The problem on 'in' for M2O has been solved recently : https://bugs.launchpad.net/openobject-server/+bug/651999
And for M2M/O2M, we are seeking expert opinions here at https://bugs.launchpad.net/openobject-server/+bug/626806.

Thanks.

The fix has landed in server revision 3178 <email address hidden>, including a basic testsuite, courtesy of xrg :-)