byobu-launcher should always return false if it decides not to start byobu

Bug #654608 reported by Ryan Thompson
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
byobu (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

Binary package hint: byobu

In /usr/bin/byobu-launcher, there are a number of checks for conditions in which byobu should not be started. In most of these cases, if the launcher decides not to launch byobu, it also returns false. However, there is at least one case where it returns true: if TERM=dumb. This is bad, because if you have used byobu-launcher-install any dumb login terminal will exit immediately. In particular, this breaks emacs's TRAMP functionality.

I have attached a trivial one line patch that fixes this case. I don't know if there are other cases.

Tags: patch

Related branches

Revision history for this message
Ryan Thompson (rct86) wrote :
tags: added: patch
Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Thanks for the patch.

This probably won't make Maverick, but it'll be in Natty as soon as it opens. If you think this is SRU-worth, feel free to nominate it for Maverick.

Changed in byobu (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package byobu - 3.6-0ubuntu1

---------------
byobu (3.6-0ubuntu1) natty; urgency=low

  [ Ryan Thompson ]
  * usr/bin/byobu-launcher: return false, if byobu doesn't launch because
    TERM=dumb, LP: #654608

  [ Dustin Kirkland ]
  * usr/bin/byobu: fix SSH_AUTH_SOCK breakage, define $RUN dir, LP: #664059
  * experimental/byobu.php, experimental/README: delete
 -- Dustin Kirkland <email address hidden> Wed, 15 Sep 2010 13:31:03 -0600

Changed in byobu (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.