Real name used instead of display name for members of a group

Bug #661619 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Melissa Draper

Bug Description

In a Mahoodle installation (Mahara 1.3) I have the first and last name fields locked as they are updated from Moodle and entered a display name. That is generally used throughout Mahara.

However, in a group, the real name is used in the "members" area on the homepage. In the group info box however, where I am admin, my display name is used.

The display name should also be used in the Members block.

Tags: groups
Changed in mahara:
status: New → Triaged
importance: Undecided → Low
milestone: none → 1.4.0
Revision history for this message
Sean Brennan (the-ioniser) wrote :

added small change to db call and template
patch attached

Revision history for this message
Sean Brennan (the-ioniser) wrote :
Changed in mahara:
assignee: nobody → Sean Brennan (the-ioniser)
status: Triaged → In Progress
Revision history for this message
Richard Mansfield (richard-mansfield) wrote :

Sean, just had a quick look. If you leave the template the way it was before, this patch works, because preferredname gets passed to the display_name function and then gets output in $r.name.

But if you change the template to output preferredname, everyone who doesn't have a preferredname set in the database shows up as having no name at all.

Revision history for this message
Sean Brennan (the-ioniser) wrote :

the branch edit fixes this but it could still be changed to use preferredname for overwriting r.name instead of changing to r.preferedname.
Should I just do that?

Changed in mahara:
assignee: Sean Brennan (the-ioniser) → nobody
status: In Progress → Confirmed
Changed in mahara:
milestone: 1.4.0 → none
tags: added: groups
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/913
Committed: http://gitorious.org/mahara/mahara/commit/a8fb539c171d8f9dec28bdc30735c7d5dcceb24a
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit a8fb539c171d8f9dec28bdc30735c7d5dcceb24a
Author: Melissa Draper <email address hidden>
Date: Fri Nov 25 18:11:38 2011 +1300

    Add preferredname query for group search (bug #661619)

    Makes preferred name appear in the groups about view
    instead of the first and last names.
    Based on Sean Brennan's patch.

    Change-Id: I2e4cbc4b93760759fb1cac7c8f82d41345346993
    Signed-off-by: Melissa Draper <email address hidden>

Changed in mahara:
status: Confirmed → Fix Committed
milestone: none → 1.5.0
assignee: nobody → Melissa Draper (melissa)
Melissa Draper (melissa)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.