Ubuntu
hal package

hald-runner fd leak

Bug #66939 reported by Martin Pitt
4
Affects Status Importance Assigned to Milestone
hal (Debian)
Fix Released
Unknown
hal (Ubuntu)
Fix Released
Medium
Martin Pitt
Ubuntu ubuntu-6.10

Bug Description

<Kamion> pitti: is it just me, or is there a really nasty fd leak in hald-runner/runner.c:run_exited?
<Kamion> pitti: it never seems to close rd->stderr_v
<Kamion> pitti: I have a hald-runner here with 1015 fds open, as a result of which I can't suspend
<Kamion> if I'm reading the code right, it only leaks for requests with error_on_stderr set

Fixed upstream in git fcb6aa0df90b7ee61a58c207896448131d3aa18

Revision history for this message
Martin Pitt (pitti) wrote :

Patch link:

http://gitweb.freedesktop.org/?p=hal.git;a=commitdiff;h=fcb6aa0df90b7ee61a58c207896448131d3aa180

Changed in hal:
assignee: nobody → pitti
importance: Undecided → Medium
status: Unconfirmed → In Progress
Revision history for this message
Martin Pitt (pitti) wrote :

Will upload after RC release.

Changed in hal:
status: In Progress → Fix Committed
Bug Watch Updater (bug-watch-updater)
Changed in hal:
status: Unknown → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote :

 hal (0.5.7.1-0ubuntu17) edgy; urgency=low
 .
   * Add debian/patches/00upstream-07-hald-runner_fdleak.patch:
     - Fix stderr file descriptor leak. This can prevent suspending and
       probably other nasty things.
     - Patch taken from upstream:
       http://gitweb.freedesktop.org/?p=hal.git;a=commit;h=fcb6aa0df90b7ee61a58c207896448131d3aa180
     - Closes: LP#66939

Changed in hal:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.