Return packingnumber hardcoded {'name':'%s (return)' % pick.name

Bug #671172 reported by Jan Verlaan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Community Openobject Addons
In Progress
Low
OpenERP Community Committers
Odoo Addons (MOVED TO GITHUB)
Fix Released
Wishlist
OpenERP R&D Addons Team 2

Bug Description

As of version 5.0.8 the returnpacking number contains the hardcoded part in it's number "(return)
See addons/stock/wizard/wizard_return.py line 83
            new_picking = pick_obj.copy(cr, uid, pick.id, {'name':'%s (return)' % pick.name,
                    'move_lines':[], 'state':'draft', 'type':new_type,
                    'date':date_cur, 'invoice_state':data['form']['invoice_state'],})

This does greatly enhance the visibility, but has a side effect when the number is used for internal barcode (EAN13) generation.
The "(" and ")" signs are used for start/end char in the barcode generation, hence the generations fails.

Quick fix is to rename the part of {'name':'%s (return)' to {'name':'%s-return'
The better option is to make use of a separate sequence generator for returnpickings where the suffix can be used.

I guess the same issue is for V6

Related branches

qdp (OpenERP) (qdp)
Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 2 (openerp-dev-addons2)
importance: Undecided → Wishlist
status: New → Confirmed
qdp (OpenERP) (qdp)
Changed in openobject-addons:
milestone: none → 6.0-rc2
summary: - [V5] Return packingnumber hardcoded {'name':'%s (return)' % pick.name
+ Return packingnumber hardcoded {'name':'%s (return)' % pick.name
Changed in community-addons:
status: New → Confirmed
importance: Undecided → Low
assignee: nobody → OpenERP Community Committers (openerp-community-committers)
Changed in community-addons:
status: Confirmed → In Progress
Revision history for this message
Rohan Nayani(Open ERP) (ron-tinyerp) wrote :

Hello Jan,

It has been fixed in lp:~openerp-dev/openobject-addons/ron-dev-addons2
Revision ID: <email address hidden>
Revision num: 5078.
It will be available in trunk soon,

Changed in openobject-addons:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.