Custom scripts stopped working after upgrade to 3.7

Bug #673728 reported by Jorge E. Gómez
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
byobu
Fix Released
High
Dustin Kirkland 
byobu (Ubuntu)
Fix Released
High
Dustin Kirkland 

Bug Description

I moved the byobu config folder from .byobu to .local/share/byobu, including the bin folder with working custom scripts, checked that custom scripts were enabled in the config file, but they just don show.

Running byobu-status custom throws this error (running byobu-status with any other filename in /usr/lib/byobu works fine):

/usr/lib/byobu/custom: 49: Syntax error: Unterminated quoted string

Related branches

Revision history for this message
Jorge E. Gómez (jorgeegomez) wrote :

This happens on a Hardy server

Changed in byobu:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Dustin Kirkland (kirkland)
Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Should be fixed in 3.8.

Changed in byobu:
status: In Progress → Fix Released
Revision history for this message
Jorge E. Gómez (jorgeegomez) wrote :

Sorry, I haven't been able to make it work; I'm still getting this with 3.8:

$ byobu-status custom
/usr/lib/byobu/custom: 49: Syntax error: Unterminated quoted string

(my /bin/sh points to dash, which I believe is default for Hardy; but changing the sh-bang to bash in byobu-status doesn't change the error)

This is a relatively up to date Hardy install; I'm missing the latest libc upgrades, but i don't think that makes a difference. Anything else I can try?

Revision history for this message
Jorge E. Gómez (jorgeegomez) wrote :

There is a typo on /usr/lib/byobu/custom line 31 (version 3.8), it's missing closing quotes:

for i in "$DATA/bin/[0-9]*_*; do

Sadly, fixing the typo doesn't make my custom bin scripts appear on the status line. They appear with their proper values when I run byobu-status-detail

Changed in byobu:
status: Fix Released → Fix Committed
Changed in byobu (Ubuntu):
status: New → Fix Committed
importance: Undecided → High
assignee: nobody → Dustin Kirkland (kirkland)
Revision history for this message
Jorge E. Gómez (jorgeegomez) wrote :

The fix on 3.10 branch works. My comment (#4) didn't really fix the typo (I misplaced the closing qoutes).

I confirm the bug fixed on Hardy and Lucid.

Revision history for this message
Dustin Kirkland  (kirkland) wrote : Re: [Bug 673728] Re: Custom scripts stopped working after upgrade to 3.7

Thanks for the followup. Sorry about the brain fart.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package byobu - 3.10-0ubuntu1

---------------
byobu (3.10-0ubuntu1) natty; urgency=low

  * usr/lib/byobu/custom: fix typo in for loop, LP: #673728, thanks for
    the triage Jorge E. Gómez
  * usr/bin/byobu-janitor: make sure this runs to completion, LP: #676605
  * usr/lib/byobu/cpu_freq: scale bogomips by number of processors, if
    using bogomips to estimate frequency, LP: #675442
  * etc/byobu/statusrc, usr/bin/byobu-config, usr/lib/byobu/Makefile.am,
    usr/lib/byobu/swap, usr/share/byobu/profiles/common,
    usr/share/man/man1/byobu.1: add a swap memory usage notification,
    LP: #677259
  * usr/lib/byobu/release: fix the ubuntu devel release printing
 -- Dustin Kirkland <email address hidden> Fri, 12 Nov 2010 22:45:25 -0600

Changed in byobu (Ubuntu):
status: Fix Committed → Fix Released
Changed in byobu:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.