addOrUpdateEntriesFromTarball expects the tarball in memory, this Is Bad
Bug #674575 reported by
Julian Edwards
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Colin Watson | ||
Bug Description
Please make it accept tmp files on disk - it's risky to allow arbitrarily sized files in memory, particularly since the code is called from the buildd-manager.
Related branches
lp:~cjwatson/launchpad/ttb-from-disk
- William Grant: Approve (code)
-
Diff: 541 lines (+94/-78)16 files modifiedlib/lp/translations/doc/poexport-language-pack.txt (+3/-3)
lib/lp/translations/interfaces/translationimporter.py (+7/-6)
lib/lp/translations/interfaces/translationimportqueue.py (+5/-3)
lib/lp/translations/model/translationimportqueue.py (+24/-14)
lib/lp/translations/model/translationtemplatesbuildbehaviour.py (+7/-16)
lib/lp/translations/scripts/upload_translations.py (+6/-6)
lib/lp/translations/tests/test_translationimportqueue.py (+5/-5)
lib/lp/translations/utilities/kde_po_importer.py (+12/-6)
lib/lp/translations/utilities/tests/helpers.py (+3/-2)
lib/lp/translations/utilities/tests/test_gettext_po_importer.py (+3/-2)
lib/lp/translations/utilities/tests/test_kde_po_importer.py (+3/-2)
lib/lp/translations/utilities/tests/test_mozilla_xpi_importer.py (+3/-2)
lib/lp/translations/utilities/tests/test_translation_importer.py (+6/-4)
lib/lp/translations/utilities/tests/test_xpi_import.py (+3/-3)
lib/lp/translations/utilities/tests/test_xpi_po_exporter.py (+2/-2)
lib/lp/translations/utilities/tests/test_xpi_search.py (+2/-2)
Revision history for this message
| Julian Edwards (julian-edwards) wrote | #1 |
| affects: | malone → rosetta |
| Changed in rosetta: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| tags: | added: import-queue |
| Changed in launchpad: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Colin Watson (cjwatson) |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
oops, helps if I get the right project.