vmbuilder fails to unmount cdrom cleanly
Bug #685258 reported by
Neil Wilson
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
vm-builder (Ubuntu) |
Fix Released
|
Low
|
Serge Hallyn |
Bug Description
When using a cd image for building machines, vmbuilder always leaves the loop device setup.
ProblemType: Bug
DistroRelease: Ubuntu 10.10
Package: python-vm-builder 0.12.4-0ubuntu1.1
ProcVersionSign
Uname: Linux 2.6.35-23-generic x86_64
Architecture: amd64
Date: Sat Dec 4 18:51:35 2010
InstallationMedia: Ubuntu 9.10 "Karmic Koala" - Release amd64 (20091027)
PackageArchitec
ProcEnviron:
PATH=(custom, user)
LANG=en_GB.utf8
SHELL=/bin/bash
SourcePackage: vm-builder
Related branches
lp:~serge-hallyn/vmbuilder/cleanup-iso
- Serge Hallyn: Approve
-
Diff: 20 lines (+2/-1)1 file modifiedVMBuilder/distro.py (+2/-1)
tags: | added: patch |
Changed in vm-builder (Ubuntu): | |
importance: | Undecided → Low |
assignee: | nobody → Serge Hallyn (serge-hallyn) |
Changed in vm-builder (Ubuntu): | |
status: | Confirmed → In Progress |
Changed in vm-builder (Ubuntu): | |
status: | In Progress → Fix Committed |
To post a comment you must log in.
The cleanup on exception was commented out.
If there isn't a reason for that then the attached patch runs cleanup on BaseException (to catch interrupts) and after post_install, which removes the iso mount.