Ubuntu
apticron package

Bashism in /etc/cron.daily/apticron

Bug #69438 reported by Sebastian Breier
34
This bug affects 1 person
Affects Status Importance Assigned to Milestone
apticron (Debian)
Fix Released
Unknown
apticron (Ubuntu)
Fix Released
Undecided
Unassigned
Edgy
Fix Released
Low
Michael Vogt

Bug Description

cron sends a mail each day because the apticron cron.daily script is broken:

/etc/cron.daily/apticron:
/etc/cron.daily/apticron: 6: let: not found
sleep: missing operand
Try `sleep --help' for more information.

This is because /etc/cron.daily/apticron uses /bin/sh, which doesn't have the "let" command. The workaround is to change the script to have "!#/bin/bash" at the top.

Bug Watch Updater (bug-watch-updater)
Changed in apticron:
status: Unknown → Fix Released
Revision history for this message
Kai Kasurinen (kai-kasurinen) wrote :

Fixed in debian:

apticron (1.1.18) unstable; urgency=low
 .
   * Removed bashism in cron.daily. Thanks to Klaus Ethgen and Rodrigo Campos.
     (Closes: #381122)

Changed in apticron:
status: Unconfirmed → Confirmed
Revision history for this message
Kai Kasurinen (kai-kasurinen) wrote :

Thanks for the bug report.

I'm closing this bug because it has been fixed in Feisty.

If you need a fix for this bug in Edgy or Dapper, please follow the
instructions in the "How to request new packages" section of the
Backports wiki page:
        https://wiki.ubuntu.com/UbuntuBackports

Changed in apticron:
status: Confirmed → Fix Released
Revision history for this message
LaserJock (laserjock) wrote :

working on a SRU for this bug

Changed in apticron:
assignee: nobody → mantha
status: Unconfirmed → Confirmed
Revision history for this message
John Dong (jdong) wrote :

Preparing SRU...

Changed in apticron:
assignee: laserjock → jdong
Revision history for this message
John Dong (jdong) wrote :

Attached debdiff for edgy-proposed

Emmet Hikory (persia)
Changed in apticron:
importance: Undecided → Low
Revision history for this message
Daniel Holbach (dholbach) wrote :

Michael: can you maybe take a look at it?

Changed in apticron:
assignee: jdong → mvo
Revision history for this message
Scott Kitterman (kitterman) wrote :

I don't see crash or data loss here. Is this really SRU worthy?

Revision history for this message
Jonathan Hitchcock (vhata) wrote :

apticron's purpose is to be run by cron every so often, and check the apt repositories.

It completely fails to run in edgy and feisty, because it uses dash-incompatible bashisms, and edgy and feisty use dash.

Surely "completely failing to run" is at least equivalent to a crash?

Revision history for this message
Scott Kitterman (kitterman) wrote : Re: [Bug 69438] Re: Bashism in /etc/cron.daily/apticron

OK. I agree with that. I didn't get completely fails to run from reading
the bug. Nevermind then.

deadwill (deadwill-deactivatedaccount)
Changed in apticron:
assignee: mvo → xxxxx1
status: Confirmed → In Progress
Revision history for this message
Michael Vogt (mvo) wrote :

The diff looks good to me.

Revision history for this message
deadwill (deadwill-deactivatedaccount) wrote :

debdiff as attachment (changed maintainer/xsbc-original-mantainer too).

Changed in apticron:
assignee: xxxxx1 → nobody
status: In Progress → Confirmed
Revision history for this message
deadwill (deadwill-deactivatedaccount) wrote :

since maintainer/xsbc-original-maintainer change is not needed. we can discard my previous debdiff and use jdong's instead.

Revision history for this message
Daniel Holbach (dholbach) wrote :

Michael: can you sponsor it then too?

Changed in apticron:
assignee: nobody → mvo
Revision history for this message
Michael Vogt (mvo) wrote :

I have uploaded it now.

Changed in apticron:
status: Confirmed → Fix Committed
Revision history for this message
Jonathan Riddell (jr) wrote :

accepted into edgy-proposed

Revision history for this message
Martin Pitt (pitti) wrote :

Please someone test this, this has been sitting in -proposed for a fair while already.

Revision history for this message
Luca Falavigna (dktrkranz) wrote :

Fix works for me on Edgy.

Revision history for this message
Daniel Schwitzgebel (schwitzd) wrote :

Fix works on edgy

Revision history for this message
Martin Pitt (pitti) wrote :

Copied to edgy-updates.

Changed in apticron:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.