[PATCH] Termio bug in xjdic client/standalone
Bug #69738 reported by
Marcus Comstedt
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| xjdic (Ubuntu) |
Fix Released
|
Wishlist
|
Luke Yelavich | ||
Bug Description
The function ioctlraw() in xjdfrontend.c uses hardcoded numeric indices into the c_cc array of struct termio. These indices happen to be correct for e.g. Solaris which overloads VEOF and VEOL with VMIN and VTIME, giving both the indices 4 and 5 (which happen to be the numeric values used in the code), however they are wrong for Linux which has given unique indices for all entries, causing the VMIN and VTIME to get other values.
The correct fix is to simply replace the uses of "4" and "5" with "VMIN" and "VTIME" (this fix is portable to other systems as well). I'll attach a patch for this to this bug report.
// Marcus
Related branches
Revision history for this message
| Marcus Comstedt (marcus-mc) wrote | #1 |
| Changed in xjdic: | |
| importance: | Undecided → Wishlist |
| Changed in xjdic: | |
| assignee: | nobody → themuso |
| status: | Unconfirmed → In Progress |
Revision history for this message
| Luke Yelavich (themuso) wrote | #2 |
| Changed in xjdic: | |
| status: | In Progress → Fix Committed |
| Changed in xjdic: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sat, 17 Mar 2007 10:27:48 +1100
Source: xjdic
Binary: xjdic
Architecture: source
Version: 24-6ubuntu1
Distribution: feisty
Urgency: low
Maintainer: Ubuntu MOTU Developers <email address hidden>
Changed-By: Luke Yelavich <email address hidden>
Description:
xjdic - Japanese-English dictionary search program
Launchpad-
Changes:
xjdic (24-6ubuntu1) feisty; urgency=low
.
* Patch to replace hardcoded numeric indices with portable symbolic
constants. Thanks to Marcus Comstedt. (Closes LP: #69738)
* Update maintainer field to MOTU.
Files:
7615c18d38188b
52970b39848e49
Original-
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
iD8DBQFF+
tucgk2vGXRTc/
=a/+q
-----END PGP SIGNATURE-----