Binary package hint: indicator-appmenu
Previously, when an application dropped off the bus, indicator-appmenu would catch the NameOwnerChanged signal and properties_destroyed would unref the WindowMenus instance, causing it to be destroyed.
In the GDbus port, each WindowMenus instance connects to the notify::g-name-owner signal.
However, this never actually fires, as it only works for well known bus names (see this code snippet from gdbusproxy.c:async_initable_init_first):
if (proxy->priv->name != NULL && !g_dbus_is_unique_name (proxy->priv->name))
{
proxy->priv->name_owner_changed_subscription_id =
g_dbus_connection_signal_subscribe (proxy->priv->connection,
"org.freedesktop.DBus", /* name */
"org.freedesktop.DBus", /* interface */
"NameOwnerChanged", /* signal name */
"/org/freedesktop/DBus", /* path */
proxy->priv->name, /* arg0 */
G_DBUS_SIGNAL_FLAGS_NONE,
on_name_owner_changed,
proxy,
NULL);
}
The side effect of this is that the panel now leaks WindowMenus instances. And if applications reuse XID's, then things get really messy (and Firefox windows always seem to get the same XID, I'm not sure why though...)
Hmmm, I'm misunderstanding how it used to work, as the destroy signal from DbusGProxy is only fired when the proxy is destroyed, and not when the application disappears off the bus.
This used to work somehow though.
The new code in indicator-appmenu (listening to the notify: