Call to fwts_passed is missing in some tests

Thanks Sylvain for spotting these mistakes.

I've address this issue in several ways:

1. Some tests didn't report any pass/fail since they were just collecting data - this is useful to allow one to identify a machine or sanity check the firmware. In this case, these tests returned a "information" state, rather that a pass/fail/aborted/skipped state.

2. Other tests, such as apicinstance were definitely missing the fwts_passed() state setting call, so I've added that.

3. Some tests (not those listed in comment #1) were not reporting pass/failed because they could not proceed with the test, e.g. no virtualisation support, missing tables, so these tests I've marked as "skipped" tests because we cannot run them.

The updated version is in the fwts devel ppa: ppa:firmware-testing-team/ppa-fwts-devel

please let me know if this resolves the issue. Then I can get this uploaded into universe. Thanks.

Thanks a lot Colin, this solves perfectly the issue, I can now easily parse the fwts output and translate test status in checkbox format.

This bug was fixed in the package fwts - 0.22.00

---------------
fwts (0.22.00) natty; urgency=low

  * New version for Natty release (LP: #720271)
  * New upstream version 0.22.00

fwts (0.21.15) natty; urgency=low

  * summary: collate summary items for a more compact summary.
  * klog: add better progress feedback when scanning large logs.
  * args: fix optind offset bug.
  * klog: add _BCM execution failure check.
  * klog: add more intelligence to FADT checking.
  * New upstream version 0.21.15

fwts (0.21.14) natty; urgency=low

  * acpi: s3,s4: break up pass/fail message summary.
  * New upstream version 0.21.14

fwts (0.21.13) natty; urgency=low

  * Print informational count when non-zero
  * tidy up progress output.
  * change results text "informational" to "info only".
  * cpu microcode test: remove need to alloc/free cpu list.
  * bios mtrr test: check for list_new NULL return.
  * arg handling: remove need for alloc/free of options_list
  * sort tests on name when dumping list of available tests.
  * New upstream version 0.21.13

fwts (0.21.12) natty; urgency=low

  * Print informational count when non-zero
  * New upstream version 0.21.12

fwts (0.21.11) natty; urgency=low

  * Fix skipped message truncation
  * Make static libs into shared libs
  * New upstream version 0.21.11

fwts (0.21.10) natty; urgency=low

  * Extend progress feedback.
  * New upstream version 0.21.10

fwts (0.21.09) natty; urgency=low

  * Add more feedback during s3, s4 tests.
  * Add better arg checking post arg parsing.
  * Fix a bunch of typos in s3, s4 help.
  * New upstream version 0.21.09

fwts (0.21.08) natty; urgency=low

  * Ensure all tests log a passed/failed/skipped/aborted/infoonly state (LP: #715755)
  * Add --s3-device-check-delay option
  * Add --s4-device-check-delay option
  * New upstream version 0.21.08

fwts (0.21.07) natty; urgency=low

  * Add --s3-quirks option
  * Add --s4-quirks option
  * Update man page
  * New upstream version 0.21.07

fwts (0.21.06) natty; urgency=low

  * Add hwinfo device checking for s3 and s4 tests
  * Update man page
  * New upstream version 0.21.06

fwts (0.21.05) natty; urgency=low

  * acpi: dmar: don't free table as it's a cached copy.
  * New upstream version 0.21.05

fwts (0.21.04) natty; urgency=low

  * s3, s4: multiple tests must run at least twice if multiples not specified.
  * s4, s4: scan log for oopsing to catch driver/kernel breakages.
  * oops: Add test to scan for random kernel oopsing.
  * manpage - fix data/date typo.
  * New upstream version 0.21.04

fwts (0.21.03) natty; urgency=low

  * Add uefidump to dump UEFI variables
  * Fix cmosdump - was dumping too much data in hex dump.
  * Add klog check for banned ioport operations from AML.
  * New upstream version 0.21.03

fwts (0.21.02) natty; urgency=low

  * Add --s4-min-delay, --s4-max-delay, --s4-delay-delta S4 delay options
  * New upstream version 0.21.02

fwts (0.21.01) natty; urgency=low

  * Fix null pointer bug
  * New upstream version 0.21.01
 -- Colin King <email address hidden> Wed, 16 Feb 2011 18:47:59 +0000