Image_properties 'key' column collides with SQL KEY keyword
Bug #726685 reported by
Rick Harris
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Glance |
Fix Released
|
Low
|
Jay Pipes | ||
Bug Description
Currently we use the column name 'key' in our image_properties table. This is a problem since `KEY` is a keyword in SQL. This makes working with this table using CLI tools a little difficult.
Alternative names:
* name (makes sense in context of name-value-pairs NVP)
* prop_key
I prefer 'name'. Thoughts?
Related branches
lp:~jaypipes/glance/bug726685
- Rick Harris (community): Approve
- Glance Core security contacts: Pending requested
-
Diff: 319 lines (+218/-13)9 files modifiedglance/registry/db/api.py (+5/-5)
glance/registry/db/migrate_repo/versions/006_key_to_name.py (+93/-0)
glance/registry/db/migrate_repo/versions/006_mysql_downgrade.sql (+11/-0)
glance/registry/db/migrate_repo/versions/006_mysql_upgrade.sql (+11/-0)
glance/registry/db/migrate_repo/versions/006_sqlite_downgrade.sql (+46/-0)
glance/registry/db/migrate_repo/versions/006_sqlite_upgrade.sql (+46/-0)
glance/registry/db/models.py (+2/-4)
glance/registry/server.py (+1/-1)
tests/stubs.py (+3/-3)
Revision history for this message
| Jay Pipes (jaypipes) wrote | #1 |
| Changed in glance: | |
| status: | New → Confirmed |
| importance: | Undecided → Low |
| Changed in glance: | |
| assignee: | nobody → Jay Pipes (jaypipes) |
| milestone: | none → cactus-2011-04-07 |
| Changed in glance: | |
| status: | Confirmed → In Progress |
| Changed in glance: | |
| status: | In Progress → Fix Committed |
| Changed in glance: | |
| milestone: | cactus-2011-04-07 → 2011.2 |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
name is fine by me.