[6.0] diagram view (workflow) fails when labels contain non-ASCII characters or use m2o fields (e.g when showing group on wkf)

Bug #727263 reported by Jacques-Etienne Baudoux
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Server (MOVED TO GITHUB)
Fix Released
Low
OpenERP's Framework R&D

Bug Description

Reproduce by doing one of these with GTK client:
- change diagram view of workflow to display group_id, and notice how it fails as soon as you display a workflow diagram where a group_id is set on some transition
- or change one of the fields values that are used as labels and put some accented text in it, such as "ééé" and see how it fails to render the diagram

------------ original desc ---------
I suggest to put the each element of the edge label on a separate line. And in the workflow diagram view, to display the group which is a very important business info in the workflow representation.
Merge proposal concerns:
client/bin/widget/view/diagram_gtk/parser.py : cleaning of the ugly code. Need to be merged before server improvement
server/bin/addons/base/ir/workflow/workflow_view.xml : display group
server/bin/addons/base/ir/ir_ui_view.py : improve label

Other improvement ideas are :
- do not define transition.condition as required with default value 'True'. The condition is not required. Making it not required will prevent polluting the diagram with "True" on all transitions without conditions.
- do not generate plenty of time the diagram when switching to diagram view, leaving it, or browsing. Generate it once, it should be enough.
-----------------------------------

Tags: profserv

Related branches

Revision history for this message
Jacques-Etienne Baudoux (jbaudoux) wrote :
Changed in openobject-server:
assignee: nobody → OpenERP's Framework R&D (openerp-dev-framework)
importance: Undecided → Wishlist
status: New → Confirmed
summary: - [6.0] diagram view (workflow) doesn't show group in GTK
+ [6.0] diagram view (workflow) fails when labels contain non-ASCII
+ characters or use m2o fields (e.g when showing group on wkf)
Changed in openobject-server:
importance: Wishlist → Low
description: updated
tags: added: profserv
Revision history for this message
Jacques-Etienne Baudoux (jbaudoux) wrote :

Added support for utf-8
Fixes are in the branches (stacked on 6.0) :
lp:~jba-openerp/openobject-server/6.0-bugfix-727263
lp:~jba-openerp/openobject-client/6.0-bugfix-727263

Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

Hello Jacques-Etienne,

Thanks for the fix, there is a problem while merging your direct branch to the trunk client "lp:~jba-openerp/openobject-client/trunk-bugfix-727263" it results in almost 13 conflicts.. can you please resolve this conflicts by merging your branch with the trunk client and then send a merge proposal for this branch.

The server branch has no conflict issue but it would be nice if you send a merge proposal for the same

providing a prerequisite branch as the client one.

Thanks,

Revision history for this message
gpa(OpenERP) (gpa-openerp) wrote :

Following changes are done in the branch lp:~openerp-dev/openobject-server/trunk-bug-727263-gpa with improvement.

Thanks

Changed in openobject-server:
status: Confirmed → Fix Committed
Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

The server-side fix has landed in trunk at revision 3624 revid: <email address hidden>.
The corresponding GTK fix was merged in trunk at revision 1952 revid: <email address hidden>

Thanks for reporting and providing the patches!

Changed in openobject-server:
milestone: none → 6.1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.