Standardize BaseImageServices handling of timestamps
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenStack Compute (nova) |
Fix Released
|
Medium
|
Mark Washenberger | ||
Bug Description
We need to standardize/
This bug arose out of the related-images mergeprop, specifically:
> 530 + # FIXME(sirp): The ImageService and API use two different formats for
> 531 + # timestamps. Ultimately, the ImageService should probably use datetime
> 532 + # objects
> 533 + NOW_SERVICE_STR = "2010-10-
> 534 + NOW_API_STR = "2010-10-
>
> This is a very good point. Would you mind logging a bug to ensure the BaseImageService API docstrings indicate the format of timestamps and that all image services' timestamp fields conform to that interfacem, please? Thanks!
Related branches
- Jay Pipes (community): Approve
- Matt Dietz (community): Approve
- Brian Waldon (community): Approve
-
Diff: 508 lines (+282/-42)7 files modifiednova/api/openstack/images.py (+6/-0)
nova/image/glance.py (+29/-7)
nova/image/service.py (+8/-8)
nova/tests/api/openstack/fakes.py (+14/-6)
nova/tests/api/openstack/test_images.py (+21/-21)
nova/tests/image/__init__.py (+16/-0)
nova/tests/image/test_glance.py (+188/-0)
| Changed in nova: | |
| importance: | Undecided → Medium |
| status: | New → Confirmed |
| Mark Washenberger (markwash) wrote | #1 |
| Rick Harris (rconradharris) wrote | #2 |
| Changed in nova: | |
| assignee: | nobody → Mark Washenberger (markwash) |
| Changed in nova: | |
| status: | Confirmed → Fix Committed |
| Changed in nova: | |
| milestone: | none → 2011.2 |
| status: | Fix Committed → Fix Released |
I can work on this one.
My plan:
* Update base image service documentation interface
* Add create / update time support to local image service, make it return datetime objects
* deserialize iso8601 date format in glance client to datetime objects
* find and fix references to the date elsewhere in nova code, presumably the ec2 and os apis
* fix the date format for what is returned by ec2/os apis
Anybody already working on this and want me to leave off?
Do I need to do anything to lp:glance?