[FFe] Please merge lintian 2.5.0~rc3 (main) from Debian unstable (main)

Bug #769101 reported by أحمد المحمودي (Ahmed El-Mahmoudy)
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
lintian (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: lintian

Please merge lintian 2.5.0~rc3 from Debian unstable. It fixes a bunch of bugs, but also introduces some new tags. The new missing-pre-dependency-on-multiarch-support tag is useful for the multiarch support in natty. The regression risk is relatively low due to the big test suite of lintian.

lintian (2.5.0~rc3ubuntu1) natty; urgency=low

  * Merge from Debian unstable. Remaining changes:
    - Don't warn about a symlinked changelog file in Ubuntu due to CDBS.
    - Add no-upstream-changelog tag to cruft-general-test-suite,
      cruft-general-upstream, cruft-upstream-binaries, fields-no-homepage,
      patch-systems-no-patch-system tests.
    - checks/changelog-file.desc, t/tests/legacy-libbaz/tags,
      testset/tags.libbaz: Drop debian-changelog-file-is-a-symlink tag.
    - t/tests/changelog-file-symlink, t/tests/init.d-symlink: Drop these tests.
    - checks/init.d: fix LP: #496798 again; upstream only took part of our
      patch and the rest of the fix was dropped in the last merge; per
      maintainer's comments in Debian bug #569492, Ubuntu will need to
      carry this fix for the time being
    - Add wrong-name-for-upstream-changelog tag to changelog-file-extra-upstream
      test.
    - Disable pkgbinarymangler for the test run to fix the FTBFS.
    - Drop debug-symbols-directly-in-usr-lib-debug from binaries-general, to
      fix FTBFS on i386 (LP: #756135)
    - t/tests/fields-multi-arch: Do not test invalid Multi-Arch field, because
      dpkg-deb will already fail.
  * Dropped changes:
    - Prefer libtest-simple-perl (>= 0.93) to perl (>= 5.12).
    - Dump build logs for tests that FTBFS.
    - Ubuntu uses i686-linux-gnu instead of i486-linux-gnu for i386.

 -- أحمد المحمودي (Ahmed El-Mahmoudy) <email address hidden> Thu, 21 Apr 2011 19:54:42 +0200

lintian (2.5.0~rc3) unstable; urgency=low

  * Summary of tag changes:
    + Added:
      - dir-or-file-in-run
      - intra-source-package-circular-dependency
      - package-contains-broken-symlink
      - classpath-contains-relative-path
      - jar-not-in-usr-share
      - executable-jar-without-main-class
      - missing-dep-on-jarwrapper
      - missing-classpath
      - javalib-but-no-public-jars
      - missing-manifest
      - codeless-jar
      - missing-pre-dependency-on-multiarch-support

  * checks/*.desc:
    + [NT] Updated the Needs-Info field to include the new
      collections where needed.
  * checks/binaries:
    + [NT] Accepted patch from Loïc Minier to support the armhf
      architecture. (Closes: #618587)
    + [NT] Drop wrong checks for multiarch directories. Multiarch
      directories are only allowed in packages of the given architecture.
      Thanks to Steve R. Langasek for the patch.
  * checks/circular-deps{,.desc}:
    + [NT] Added to check for circular dependencies between
      binaries from the same source. It requires all binaries
      packages to be present as well as the source package to be
      effective. Thanks to Bill Allombert for the suggestion.
      (Closes: #316283)
  * checks/debhelper:
    + [NT] Use new alt-dh_commands data file to fetch alternative
      dependencies for dh_commands, which are sometimes provided
      indirectly by meta or API packages.
  * checks/fields:
    + [NT] Do not emit needless-dependency-on-jre for libX-gcj
      packages and only emit the tag at most once per package.
      Thanks to Rene Engelhard for the report.
      (Closes: #622396)
  * checks/files{,.desc}:
    + [NT] Added dir-or-file-in-run tag. (Closes: #623031)
    + [NT] New tag missing-pre-dependency-on-multiarch-support,
      Severity: serious, to warn when a package installs libraries to the
      multiarch directory without taking care of upgrades. Thanks to
      Steve R. Langasek for the patch.

  * checks/java{,.desc}:
    + [NT] Added file based on patches submitted by Vicent Fourmond.
      This new file checks for jar files in weird locations.
      (Closes: #620829, #575447)
  * checks/manpages:
    + [NT] Fixed false-positive binary-without-manpage when the
      manpage is in a direct dependency of the package and the
      package is checked together with its dependency.
      (Closes: #120323)
  * checks/scripts:
    + [NT] Fixed false positive missing-dep-for-interpreter, if
      the interpreter was dash, since dash is now essential.
      (Closes: #620120)
  * checks/symlinks{,.desc}:
    + [NT] New file that checks for broken symlinks. A symlink
      is considered broken if it does not exist in the package
      itself or in its direct dependecies. Since only absolute
      symlinks are checked at the moment, this only partly
      fixes #217023.

  * collection/*.desc:
    + [NT] Updated the Needs-Info field to include the new
      collections where needed.
  * collection/{bin-pkg-control,fields,index}{,.desc}:
    + [NT] Added to replace various unpack scripts.
  * collection/java-info{,.desc}:
    + [NT] Accepted patch from Vincent Fourmond to implement
      Java related data collection.

  * data/binaries/multiarch:
    + [NT] Removed by patch from Steve R. Langasek.
  * data/debhelper/alt-dh_commands:
    + [NT] New file; contains alternative dependencies for
      dh_python2 and dh_python3. (Closes: #614879)
  * data/fields/architectures:
    + [NT] Updated to include armhf.
  * data/files/triplets:
    + [NT] Updated to include armhf triplet.
    + [NT] Refresh with the final approved multiarch paths by patch
      from Steve R. Langasek.
  * data/output/manual-references:
    + [NT] Accepted patch from Vincent Fourmond to add the links
      to the Java Policy.
  * data/spelling/corrections:
    + [NT] Added a lot of spelling mistakes with corrections.
      Kudos to Kevin Ryde for these. (Closes: #619075)
  * data/spelling/corrections-multiword:
    + [NT] Removed "helps to" as a spelling mistake. Thanks to
      Nicholas Bamber for the report. (Closes: #622124)
  * data/standards-version/release-dates:
    + [NT] Added 3.9.2 as the newest Standards-Version. Thanks to
      Sven Joachim for the report. (Closes: #621667)

  * debian/control:
    + [NT] Bumped Standards-Version to 3.9.2.
    + [NT] Updated Build-Depends for debiandoc -> docbook change of
      the manual.
    + [NT] Added missing Build-Depends on libhtml-parser-perl. Also
      added it to suggests, since it is used for XML output.
  * debian/{docs,rules}:
    + [NT] Updated to use/install docbook instead of debiandoc.

  * doc/lintianrc.example:
    + [NT] Removed reference to LINTIAN_UNPACK_LEVEL.
  * doc/lintian.sgml:
    + [RG] Removed file - replaced by doc/lintian.xml.
  * doc/lintian.xml:
    + [RG] Added to migrate away from debiandoc. (Closes: #587925)

  * frontend/lintian:
    + [NT] Removed the deprecated --unpack-level argument. Only
      two unpack levels were available and they were equal to
      the --remove and --unpack options.
    + [NT] Stopped accepting the environment/config variables
      LINTIAN_UNPACK_LEVEL and LINTIAN_SECTION. The former is
      redundant as explained above and the latter was deprecated
      in favor of LINTIAN_AREA.
    + [NT] Refactored the frontend to group packages together based
      on their source package. This allows for cross-package checks.
      (Closes: #513663)

  * lib/{Lab/Package,Lintian/Processable*}.pm:
    + [NT] Added files to assist in package grouping.
  * lib/Lintian/Command/Simple.pm:
    + [NT] Added support for chanding directory before running the
      command.
  * lib/Lintian/Collect.pm,lib/Lintian/Collect/*.pm:
    + [NT] Removed assumption that all the information handled by
      these are available in the current directory.
  * lib/Lintian/Schedule.pm:
    + [NT] Removed file, replaced by Lintian::ProcessablePool.

  * private/refresh-archs:
    + [SRL] update to output directory mappings based on DEB_HOST_MULTIARCH
      instead of DEB_HOST_GNU_TYPE.
  * private/runtests:
    + [NT] Added support for dumping build logs if a test fails.
      (Closes: #621658)
    + [NT] Disabled pkgbinarymangler during tests. (Closes: #621681)

  * t/tests/binaries-from-other-arch:
    + [NT] Accepted patch from Benjamin Drung to accept i686-linux-gnu
      as a valid triplet. This fixes test failure in Ubuntu.
      (Closes: #622974)

  * unpack/unpack-{binpkg,changes}-l1:
    + [NT] Removed unpack scripts for binpkg and changes as these have
      been replaced by collections.

 -- Niels Thykier <email address hidden> Thu, 21 Apr 2011 12:29:45 +0200

Tags: patch
Revision history for this message
أحمد المحمودي (Ahmed El-Mahmoudy) (aelmahmoudy) wrote :
Revision history for this message
Adam D. Barratt (adam-barratt) wrote :

--- lintian-2.5.0~rc3/debian/rules 2011-04-17 17:48:14.000000000 +0200
+++ lintian-2.5.0~rc3ubuntu1/debian/rules 2011-04-21 19:20:39.000000000 +0200
@@ -26,13 +26,11 @@
[...]
- private/runtests $(PAR_ARGS) $(onlyrun)
+ NO_PKG_MANGLE=true private/runtests $(PAR_ARGS) $(onlyrun)

This is wrong, for a couple of reasons:

a) private/runtests already contains logic to set NO_PKG_MANGLE; unfortunately it didn't work in ~rc3 due to a typo. The correct fix is to take 0c511db6cb526cbc3cf8877e2a25558fa5e4f40b from upstream, which corrects that issue by correctly exporting NO_PKG_MANGLE (rather than NO_PKG_MAGNGLE)

b) debian/rules contains two different ways in which private/runtests may be called, and the above only touches one of them

Regards,

Adam

Benjamin Drung (bdrung)
summary: - Candidate revision 2.5.0~rc3ubuntu1
+ [FFe] Please merge lintian 2.5.0~rc3ubuntu1 (main) from Debian unstable
+ (main)
Revision history for this message
Benjamin Drung (bdrung) wrote : Re: [FFe] Please merge lintian 2.5.0~rc3ubuntu1 (main) from Debian unstable (main)

Sorry Ahmed, I prepared a merge earlier than you (attached). You can find a built of it in my PPA [1]. There you can find the build log too. I am using it for two days without any issues.

[1] https://launchpad.net/~bdrung/+archive/ppa

description: updated
summary: - [FFe] Please merge lintian 2.5.0~rc3ubuntu1 (main) from Debian unstable
- (main)
+ [FFe] Please merge lintian 2.5.0~rc3 (main) from Debian unstable (main)
Revision history for this message
أحمد المحمودي (Ahmed El-Mahmoudy) (aelmahmoudy) wrote : Re: [Bug 769101] Re: [FFe] Please merge lintian 2.5.0~rc3ubuntu1 (main) from Debian unstable (main)

On Sat, Apr 23, 2011 at 11:14:17AM -0000, Benjamin Drung wrote:
> Sorry Ahmed, I prepared a merge earlier than you (attached). You can
> find a built of it in my PPA [1]. There you can find the build log too.
> I am using it for two days without any issues.
---end quoted text---

No problem, but could you please drop this change:

  - Prefer libtest-simple-perl (>= 0.93) to perl (>= 5.12).

--
 ‎أحمد المحمودي (Ahmed El-Mahmoudy)
  Digital design engineer
 GPG KeyID: 0xEDDDA1B7
 GPG Fingerprint: 8206 A196 2084 7E6D 0DF8 B176 BC19 6A94 EDDD A1B7

Revision history for this message
Benjamin Drung (bdrung) wrote :

No, because Launchpad fails to detect that libtest-simple-perl should be used instead of waiting for the dependency perl >= 5.12 [1].

[1] https://launchpad.net/ubuntu/+source/lintian/2.5.0~rc1ubuntu1/+buildjob/2283540

Revision history for this message
أحمد المحمودي (Ahmed El-Mahmoudy) (aelmahmoudy) wrote : Re: [Bug 769101] Re: [FFe] Please merge lintian 2.5.0~rc3 (main) from Debian unstable (main)

On Sat, Apr 23, 2011 at 02:47:00PM -0000, Benjamin Drung wrote:
> No, because Launchpad fails to detect that libtest-simple-perl should be
> used instead of waiting for the dependency perl >= 5.12 [1].
>
> [1]
> https://launchpad.net/ubuntu/+source/lintian/2.5.0~rc1ubuntu1/+buildjob/2283540
---end quoted text---

  Shouldn't a bug be filed against Launchpad then ?

--
 ‎أحمد المحمودي (Ahmed El-Mahmoudy)
  Digital design engineer
 GPG KeyID: 0xEDDDA1B7
 GPG Fingerprint: 8206 A196 2084 7E6D 0DF8 B176 BC19 6A94 EDDD A1B7

Revision history for this message
Benjamin Drung (bdrung) wrote :

> Shouldn't a bug be filed against Launchpad then?

Yes, but it is maybe filed already.

Revision history for this message
Scott Kitterman (kitterman) wrote :

Given the trouble we had getting rc2 to build and the short time before release, nack on this for now. Upload it as soon as oneiric opens and then request a backport.

Changed in lintian (Ubuntu):
milestone: none → oneiric-alpha-1
Revision history for this message
Benjamin Drung (bdrung) wrote :

> Given the trouble we had getting rc2 to build.

I had troubles to get rc1 and rc2 to build, but they are all resolved. It builds with pkgbinarymangler enabled and on i386.

tags: added: patch
Revision history for this message
Benjamin Drung (bdrung) wrote :
Download full text (3.4 KiB)

It fails on oneiric with the new toolchain:

Running binaries-from-other-arch 1.0... building... testing... ok.
binaries-general: ---- START BUILD LOG
binaries-general: dpkg-buildpackage: export CFLAGS from dpkg-buildflags (origin: vendor): -g -O2
binaries-general: dpkg-buildpackage: export CPPFLAGS from dpkg-buildflags (origin: vendor):
binaries-general: dpkg-buildpackage: export CXXFLAGS from dpkg-buildflags (origin: vendor): -g -O2
binaries-general: dpkg-buildpackage: export FFLAGS from dpkg-buildflags (origin: vendor): -g -O2
binaries-general: dpkg-buildpackage: export LDFLAGS from dpkg-buildflags (origin: vendor): -Wl,-Bsymbolic-functions
binaries-general: dpkg-buildpackage: source package binaries-general
binaries-general: dpkg-buildpackage: source version 1.0
binaries-general: dpkg-buildpackage: source changed by Debian Lintian Maintainers <email address hidden>
binaries-general: dpkg-source -iNEVER_MATCH_ANYTHING -INEVER_MATCH_ANYTHING --before-build binaries-general-1.0
binaries-general: dpkg-buildpackage: host architecture amd64
binaries-general: fakeroot debian/rules clean
binaries-general: make[1]: Entering directory `/tmp/buildd/lintian-2.5.0~rc3ubuntu1/debian/tests/binaries-general/binaries-general-1.0'
binaries-general: dh clean
binaries-general: dh_testdir
binaries-general: dh_auto_clean
binaries-general: make[2]: Entering directory `/tmp/buildd/lintian-2.5.0~rc3ubuntu1/debian/tests/binaries-general/binaries-general-1.0'
binaries-general: rm -f basic
binaries-general: make[2]: Leaving directory `/tmp/buildd/lintian-2.5.0~rc3ubuntu1/debian/tests/binaries-general/binaries-general-1.0'
binaries-general: dh_clean
binaries-general: make[1]: Leaving directory `/tmp/buildd/lintian-2.5.0~rc3ubuntu1/debian/tests/binaries-general/binaries-general-1.0'
binaries-general: dpkg-source -iNEVER_MATCH_ANYTHING -INEVER_MATCH_ANYTHING -b binaries-general-1.0
binaries-general: dpkg-source: info: using source format `1.0'
binaries-general: dpkg-source: info: building binaries-general in binaries-general_1.0.tar.gz
binaries-general: dpkg-source: info: building binaries-general in binaries-general_1.0.dsc
binaries-general: debian/rules build
binaries-general: make[1]: Entering directory `/tmp/buildd/lintian-2.5.0~rc3ubuntu1/debian/tests/binaries-general/binaries-general-1.0'
binaries-general: dh build
binaries-general: dh_testdir
binaries-general: dh_auto_configure
binaries-general: dh_auto_build
binaries-general: make[2]: Entering directory `/tmp/buildd/lintian-2.5.0~rc3ubuntu1/debian/tests/binaries-general/binaries-general-1.0'
binaries-general: # rpath not matching any of the exceptions to the rpath checks
binaries-general: gcc -o basic basic.c -pg -Wl,--rpath,/usr/local/lib
binaries-general: # rpath shipped in the package, but one of {/usr}?/lib
binaries-general: gcc -o basiclibrpath basic.c -ph -Wl,--rpath,/usr/lib
binaries-general: gcc: error: unrecognized option '-ph'
binaries-general: make[2]: *** [all] Error 1
binaries-general: make[2]: Leaving directory `/tmp/buildd/lintian-2.5.0~rc3ubuntu1/debian/tests/binaries-general/binaries-general-1.0'
binaries-general: dh_auto_build: make -j1 returned exit code 2...

Read more...

Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (7.9 KiB)

This bug was fixed in the package lintian - 2.5.0~rc3ubuntu1

---------------
lintian (2.5.0~rc3ubuntu1) oneiric; urgency=low

  * Merge from Debian unstable (LP: #769101). Remaining changes:
    - Don't warn about a symlinked changelog file in Ubuntu due to CDBS.
    - Add no-upstream-changelog tag to cruft-general-test-suite,
      cruft-general-upstream, cruft-upstream-binaries, fields-no-homepage,
      patch-systems-no-patch-system tests.
    - checks/changelog-file.desc, t/tests/legacy-libbaz/tags,
      testset/tags.libbaz: Drop debian-changelog-file-is-a-symlink tag.
    - t/tests/changelog-file-symlink, t/tests/init.d-symlink: Drop these tests.
    - checks/init.d: fix LP: #496798 again; upstream only took part of our
      patch and the rest of the fix was dropped in the last merge; per
      maintainer's comments in Debian bug #569492, Ubuntu will need to
      carry this fix for the time being
    - Add wrong-name-for-upstream-changelog tag to changelog-file-extra-upstream
      test.
    - Prefer libtest-simple-perl (>= 0.93) to perl (>= 5.12).
    - t/tests/fields-multi-arch: Do not test invalid Multi-Arch field,
      because dpkg-deb will already fail.
    - Drop debug-symbols-directly-in-usr-lib-debug from binaries-general.
  * private/runtests: Fix typo NO_PKG_MAGNGLE -> NO_PKG_MANGLE.
  * binaries-general test: Remove unknown -ph flag from gcc 4.6 call.

lintian (2.5.0~rc3) unstable; urgency=low

  * Summary of tag changes:
    + Added:
      - dir-or-file-in-run
      - intra-source-package-circular-dependency
      - package-contains-broken-symlink
      - classpath-contains-relative-path
      - jar-not-in-usr-share
      - executable-jar-without-main-class
      - missing-dep-on-jarwrapper
      - missing-classpath
      - javalib-but-no-public-jars
      - missing-manifest
      - codeless-jar
      - missing-pre-dependency-on-multiarch-support

  * checks/*.desc:
    + [NT] Updated the Needs-Info field to include the new
      collections where needed.
  * checks/binaries:
    + [NT] Accepted patch from Loïc Minier to support the armhf
      architecture. (Closes: #618587)
    + [NT] Drop wrong checks for multiarch directories. Multiarch
      directories are only allowed in packages of the given architecture.
      Thanks to Steve R. Langasek for the patch.
  * checks/circular-deps{,.desc}:
    + [NT] Added to check for circular dependencies between
      binaries from the same source. It requires all binaries
      packages to be present as well as the source package to be
      effective. Thanks to Bill Allombert for the suggestion.
      (Closes: #316283)
  * checks/debhelper:
    + [NT] Use new alt-dh_commands data file to fetch alternative
      dependencies for dh_commands, which are sometimes provided
      indirectly by meta or API packages.
  * checks/fields:
    + [NT] Do not emit needless-dependency-on-jre for libX-gcj
      packages and only emit the tag at most once per package.
      Thanks to Rene Engelhard for the report.
      (Closes: #622396)
  * checks/files{,.desc}:
    + [NT] Added dir-or-file-in-run tag. (Closes: #623031)
    + [NT] New tag missing-pre-dependency-on-multiarch-support,
    ...

Read more...

Changed in lintian (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.