TinyMCE: height growing misbehaviour in Chrome

Bug #791854 reported by Ruslan Kabalin
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
François Marier

Bug Description

This is on gerrit/master and gerrit/1.4_STABLE so far. With TinyMCE update (b079064d) a new bug has been introduced. When user types in the text, the height of the iframe containing the editor is rapidly growing. Each keystroke (any key including backspace) results in iframe height increase by 50px.

Steps to reproduce:
* checkout gerrit/master
* open any page containing TinyMCE editor
* type in the text in the textbox.

Chrome version in use: 11.0.696.71

Tags: tinymce editor
Revision history for this message
Ruslan Kabalin (rkabalin) wrote :

It literally changes 'height' CSS property of the parent iframe. It might be some TinyMCE settings conflict or incompatibility. If there is no quick solution, then I think we should consider reverting the change.

Changed in mahara:
milestone: none → 1.4.0
Revision history for this message
Darryl Hamilton (lordp) wrote :

Still happens with Chrome 13.0.772.0, something to do with the AutoResize plugin.

Reported here http://tinymce.moxiecode.com/develop/bugtracker_view.php?id=4416

Revision history for this message
Darryl Hamilton (lordp) wrote :

Disabling the plugin (lib/web.php:123) 'fixes' the problem.

Revision history for this message
Hugh Davenport (hugh-davenport) wrote :

I can confirm on
11.0.696.71 (86024) Ubuntu 11.04

Also had an issue where tinymce didn't show up at all, and couldn't save a block.
Will file that bug seperate, not sure what caused it, or how i "fixed" it...

Cheers,

Hugh

Changed in mahara:
status: New → Confirmed
Revision history for this message
Hugh Davenport (hugh-davenport) wrote :
Revision history for this message
Ruslan Kabalin (rkabalin) wrote :

Thanks guys for looking into it. Darryl, if the fix you suggested on http://tinymce.moxiecode.com/develop/bugtracker_view.php?id=4416 does the job, I think we should use it, just reflect that in readme.mahara. Would be interesting to hear Francois and Richard's opinion?

Revision history for this message
François Marier (fmarier) wrote :

As far as I can tell, this is the patch that Darryl is suggesting.

It doesn't work for me :(

Revision history for this message
François Marier (fmarier) wrote :

While we can't roll back to the old version of tinymce (it has problems with IE9), we can disable the autoresize plugin which was added to resolve bug #530656. After all, it's still not worse than 1.3 which didn't have this plugin enabled.

Here's a change that does this: https://reviews.mahara.org/287

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/287
Committed: http://gitorious.org/mahara/mahara/commit/651fcdba81e529ffa5506c7b68756338f4ff2b98
Submitter: Francois Marier (<email address hidden>)
Branch: master

commit 651fcdba81e529ffa5506c7b68756338f4ff2b98
Author: Francois Marier <email address hidden>
Date: Sat Jun 4 16:57:15 2011 +1200

    tinymce: disable autoresize plugin (bug #791854)

    The auto-resize plugin is currently broken in Chrome:

      http://tinymce.moxiecode.com/develop/bugtracker_view.php?id=4416

    This effectively reverts 5525cb60742b19a475cdbd824c5cd567639fabd8
    and reopens bug #530656.

    Change-Id: I2729dec02247ea1eb3d5d10f9a4f4a8bf93f1b52
    Signed-off-by: Francois Marier <email address hidden>

Changed in mahara:
assignee: nobody → François Marier (fmarier)
status: Confirmed → Fix Committed
Revision history for this message
Darryl Hamilton (lordp) wrote :

Ahh, I don't think my comment on the TinyMCE bug tracker was very good - I should have added that a repack was needed.

I've attached what I think will be the packed version as a patch.

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/291
Committed: http://gitorious.org/mahara/mahara/commit/1b231d7667b7dd4451c61c4d472922ad3fcd4419
Submitter: Francois Marier (<email address hidden>)
Branch: master

commit 1b231d7667b7dd4451c61c4d472922ad3fcd4419
Author: Francois Marier <email address hidden>
Date: Tue Jun 7 13:06:05 2011 +1200

    text block: add option for larger tinymce editor

    This is a cherry-pick of the following commits:

      688a506321262dffcbe8400ccf6dd46588afb657
      b4c77eb66b07c2928f5566b6df8857eda4f15c67
      0e7a938a8b5005efca86403e156c453f1af940ae
      ff8b17d30ff7edd62eed77e58fa8141543ce95ce
      b8ca346ac2b28f01d32ea3cf61bc6930939d8750

    The original one was done to fix bug #530656 but was then reverted
    in 55a8feadbecf31725b4b3808e9e26b783b9ed873 after the tinymce
    autoresize plugin was enabled.

    However, the autoresize plugin was removed after causing problems
    in bug #791854 (see 651fcdba81e529ffa5506c7b68756338f4ff2b98) so
    we'll restore this work-around for the time being.

    Change-Id: I74176a3a155a7d9442448d09f206250b55394611
    Signed-off-by: Francois Marier <email address hidden>

Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.