Mahara

Online users sideblock icons problem

Bug #806985 reported by Ruslan Kabalin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Ruslan Kabalin

Bug Description

In the online users block, entities are used in the url to user profile image (profile_icon_url function). In some cases, entities are not decoded and incorrect user image is shown.

Tested with latest stable Chrome and FF.

See original description
Revision history for this message
Ruslan Kabalin (rkabalin) wrote :
description: updated
Changed in mahara:
status: New → Confirmed
tags: added: icons online profile
tags: added: bite-sized
Changed in mahara:
importance: Undecided → Medium
assignee: nobody → Ruslan Kabalin (rkabalin)
Revision history for this message
Ruslan Kabalin (rkabalin) wrote :

Oops... The bug has been introduced by your obedient servant in 858f1b9aa8e (Make profile_icon_url output compatible with html export filter).

Revision history for this message
Ruslan Kabalin (rkabalin) wrote :

Will try to rewrite https://reviews.mahara.org/#change,283 as Richard suggested:

I guess the other option is to make the html export filter compatible with both '&' and '&' - is it dangerous to do that? It's something I ended up doing for the download links to make them work with the media player in https://bugs.launchpad.net/mahara/+bug/548308

Changed in mahara:
importance: Medium → Low
Revision history for this message
Ruslan Kabalin (rkabalin) wrote :

https://reviews.mahara.org/#change,450

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/450
Committed: http://gitorious.org/mahara/mahara/commit/7be4d2d1c84f67a4e3bd6aabc518519463fd0507
Submitter: Francois Marier (<email address hidden>)
Branch: master

commit 7be4d2d1c84f67a4e3bd6aabc518519463fd0507
Author: Ruslan Kabalin <email address hidden>
Date: Fri Jul 8 02:44:15 2011 +1200

    Revert "Make profile_icon_url output compatible with html export filter." due to bug #806985

    This reverts commit 858f1b9aa8e2738097c33db8ceb9c8d2aa84097b

François Marier (fmarier)
Changed in mahara:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.