View access changes

Bug #807278 reported by Eugene
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Eugene

Bug Description

The following changes were requested:

- sharing of views/collections with institutions
- enable sharing options on profile page; profile page now behaves more like normal page/view (with some exceptions)
- force institution access on profile page
- add site setting to always grant logged-in users access to another user profile page

Tags: newfeature
Eugene (eugenev)
Changed in mahara:
status: New → In Progress
assignee: nobody → Eugene (eugenev)
Changed in mahara:
importance: Undecided → Wishlist
milestone: none → 1.5.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/452
Committed: http://gitorious.org/mahara/mahara/commit/fc76f3dbfa5d5953b9f0daa46867e831ce3e1b15
Submitter: Francois Marier (<email address hidden>)
Branch: master

commit fc76f3dbfa5d5953b9f0daa46867e831ce3e1b15
Author: Eugene Venter <email address hidden>
Date: Mon Jul 11 17:03:38 2011 +1200

    Sharing of views/collections with institutions

    Part of bug #807278

    Enable the ability for users to share their views/collections with
    the institutions they are members of.

    Change-Id: Id647672141610cced579dbf199690292a249e7b7
    Signed-off-by: Eugene Venter <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/455
Committed: http://gitorious.org/mahara/mahara/commit/61454f506b37ff8bdb354f5c427373858f347e82
Submitter: Hugh Davenport (<email address hidden>)
Branch: master

commit 61454f506b37ff8bdb354f5c427373858f347e82
Author: Eugene Venter <email address hidden>
Date: Tue Jul 12 11:16:59 2011 +1200

    View access record locking

    Part of bug #807278

    Make it possible to indicate and 'lock' a view access record item (in
    code)

    Change-Id: If8c6e574e7d40606269035a598586ff2a49bbe48
    Signed-off-by: Eugene Venter <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/456
Committed: http://gitorious.org/mahara/mahara/commit/e283a68ab06a199c519fac7439a5e548e3e7a169
Submitter: Hugh Davenport (<email address hidden>)
Branch: master

commit e283a68ab06a199c519fac7439a5e548e3e7a169
Author: Francois Marier <email address hidden>
Date: Wed Aug 24 15:46:53 2011 +1200

    Force institution access on profile page

    Part of bug #807278

    Change-Id: I3c01e88577262dd610f5df74f79f5150e3978dd9
    Signed-off-by: Eugene Venter <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/457
Committed: http://gitorious.org/mahara/mahara/commit/eb9c4dae90bc32a0f230a982da0505d0a3851257
Submitter: Hugh Davenport (<email address hidden>)
Branch: master

commit eb9c4dae90bc32a0f230a982da0505d0a3851257
Author: Francois Marier <email address hidden>
Date: Wed Aug 24 16:08:29 2011 +1200

    Make logged-in user access on profile configurable

    Part of bug #807278

    Add new site setting to force logged-in access to profile pages

    Change-Id: I7e1634cba16759923e3aa4c64d129d1f5280665f
    Signed-off-by: Eugene Venter <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/453
Committed: http://gitorious.org/mahara/mahara/commit/85986e6cea0ba1e8b055e6def4f603b23b2cfa53
Submitter: Hugh Davenport (<email address hidden>)
Branch: master

commit 85986e6cea0ba1e8b055e6def4f603b23b2cfa53
Author: Francois Marier <email address hidden>
Date: Wed Aug 24 16:17:41 2011 +1200

    Enable sharing options on profile page

    Part of bug #807278

    Profile page now behaves more like a normal page/view, with the
    following exceptions:
    - Not removable
    - Title, description and tags not editable
    - No advanced sharing options
    - Cannot be part of a collection
    - Not available in bulk access update options

    Change-Id: Ia42cdaee7978fe2e737a89cd79b043feb02ceb0d
    Signed-off-by: Eugene Venter <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/613
Committed: http://gitorious.org/mahara/mahara/commit/9c26c8f8dc73c6a61d8176af6cbcdab523727987
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit 9c26c8f8dc73c6a61d8176af6cbcdab523727987
Author: Francois Marier <email address hidden>
Date: Thu Aug 25 17:00:58 2011 +1200

    view access: fix broken loggedin view permissions

    This array structure was too deep and caused invalid records to
    get added to the DB on MySQL (since it doesn't have CHECK
    constraints) and errors on Postgres.

    Bug introduced in e283a68ab06a199c519fac7439a5e548e3e7a169 while
    implementing the features described in bug #807278.

    Change-Id: I65aa9b6de736294320e6d2bce2ea549a67ba2577
    Signed-off-by: Francois Marier <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/730
Committed: http://gitorious.org/mahara/mahara/commit/468bfda69322c229b34b0358d506d8dd759818de
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit 468bfda69322c229b34b0358d506d8dd759818de
Author: Richard Mansfield <email address hidden>
Date: Thu Sep 22 18:11:58 2011 +1200

    Don't add institution profile access before profile is created (bug #807278)

    When arriving at Mahara for the first time via SSO, the newly created user
    is added to an institution. During that process an attempt is made to add
    institution access to the user's profile view before it gets created. This
    patch adds a check (and when the profile view eventually gets created,
    institution access is added for all the owner's institutions).

    Change-Id: I6a6d4fc3dcb324905e67f4d52aac4160cf9ce089
    Signed-off-by: Richard Mansfield <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/732
Committed: http://gitorious.org/mahara/mahara/commit/4f0fed0e7e1c0607007aa84f1709ebb0c993e5b1
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit 4f0fed0e7e1c0607007aa84f1709ebb0c993e5b1
Author: Richard Mansfield <email address hidden>
Date: Thu Sep 22 19:05:54 2011 +1200

    Add missing ctime value when inserting institution access (bug #807278)

    When a user is added to an institution, an attempt is made to insert a
    view_access record into the database without a value for the not null
    ctime column. This patch adds a ctime value for new access records
    inserted in View::add_owner_institution_access().

    The call to ensure_record_exists has been removed, because that function
    is a bit too fragile for this case: it will fail if there is more than
    one record which matches the $whereobject passed to it.

    Change-Id: Ie6871d7137d78cd2d70ae4800b4c5613de47dfaf
    Signed-off-by: Richard Mansfield <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/748
Committed: http://gitorious.org/mahara/mahara/commit/f820ea6c52a344a45758cde56da8b4e7064c9d9b
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit f820ea6c52a344a45758cde56da8b4e7064c9d9b
Author: Richard Mansfield <email address hidden>
Date: Wed Sep 28 15:40:00 2011 +1300

    Create all profiles with logged-in access by default (bug #807278)

    There is currently only a site-wide setting for logged-in profile view
    access. This means that when two institutions share a site, and one
    wants open profiles and another only wants institution-visible profiles,
    new users in the open-profile institution must be asked to manually add
    logged-in access on their profile. Because we expect many more
    open-profile institutions than closed-profile institutions on a site, it
    makes more sense to put the onus on the closed-profile institutions to
    ensure their members remove logged-in access manually.

    This change ensures logged-in access is added to all new profiles, but
    only locks that access when the loggedinprofileviewaccess setting is on.

    Change-Id: I3375d7b2f8eb635a11879bf7758267f48f74c508
    Signed-off-by: Richard Mansfield <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/780
Committed: http://gitorious.org/mahara/mahara/commit/d72aeaf3bd9151faab86565db022314067cf2aff
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit d72aeaf3bd9151faab86565db022314067cf2aff
Author: Richard Mansfield <email address hidden>
Date: Thu Oct 6 13:06:18 2011 +1300

    Remove view title display logic from my views template (bug #860154)

    As a result of profile view access changes in bug #807278, profile
    views are displayed on the share page. So the 'editing' version
    of view titles needs to be displayed in two places (my views/
    group views etc., and on the share page). It makes sense to use
    the same View methods in both cases, and remove the old logic to
    get the view title and url from the template.

    Change-Id: Ifa36651dc3358acd71ca63407df79799ddd47299
    Signed-off-by: Richard Mansfield <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/779
Committed: http://gitorious.org/mahara/mahara/commit/1661f54e0f13bf6b7aeb82ef1de504e6d429a340
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit 1661f54e0f13bf6b7aeb82ef1de504e6d429a340
Author: Richard Mansfield <email address hidden>
Date: Thu Oct 6 12:29:07 2011 +1300

    Overwrite the profile view title on the Share page (bug #860154)

    The profile view title is now displayed on the share page, due to
    recent changes in profile view access (see bug #807278). However
    the view title from the database is now displayed on the share page
    instead of the translatable string.

    Change-Id: Ic691469731923faa0cef0c204b1207a9152e9fe2
    Signed-off-by: Richard Mansfield <email address hidden>

tags: added: newfeature
Revision history for this message
Melissa Draper (melissa) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPjrXHAAoJECXBtiziiXdcU94IALII/v8XTSOgD0jBkOXYzDms
uLkrvC+Z5YqYhQVjIR5cVYg7X3SJPUjuaorS2uVVfIkGlz+38KdZdczOYV+JaNQV
S8aVo/Rqrsx8h6fKtVAgTl8bd1CCMos1YnrOTNvqoYSOV2iGSSX/paQf6R9BjDbz
hx6GM7pkUp/gOa3Zqo+E6NfUrMWASanjbh9kbHdm09L7/10f7a5Q9w2Cf5o1yjC7
xqM9hEbPe32C9tBBcXDGPzQDFpJ6b6Rys2dzt6NTNkv2FCyzKS4RLwGDUDRNBEEZ
iYxQ5wJJaxW+/RO8k4lGYSo7Mtt99aIxhkQX7DKxcEoOSNMdPUi9ptwjolgG4iI=
=AeF+
-----END PGP SIGNATURE-----

Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.