Launchpad itself

DistroSeriesDifferenceBaseView modifies shared objects

Bug #809985 reported by Gavin Panella
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Gavin Panella

Bug Description

Nothing is breaking right now because the production LP app servers
are running single-threaded. However, this may not always be the case.

The culprits:

    def initialize_sync_label(self, label):
        self.__class__.actions.byname['actions.sync'].label = label

    def setUpFields(self):
        ...
        choice = self.form_fields['selected_differences'].field.value_type
        choice.vocabulary = diffs_vocabulary

Related branches

lp:~allenap/launchpad/dsd-base-view-dont-modify-globals-bug-809985
William Grant: Approve (code)
Diff: 25 lines (+12/-3)
1 file modified
lib/lp/registry/browser/distroseries.py (+12/-3)
Julian Edwards (julian-edwards)
tags: added: tech-debt
Revision history for this message
Gavin Panella (allenap) wrote :

The "selected_differences" field part of this bug is being addressed
as a side-effect of fixing bug 817408.

Gavin Panella (allenap)
Changed in launchpad:
assignee: nobody → Gavin Panella (allenap)
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r13585 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13585>.

tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Gavin Panella (allenap)
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.