Launchpad itself

Failed PackageCopyJobs should show up on the PPA page somehow

Bug #812869 reported by Julian Edwards
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Colin Watson

Bug Description

When using copyPackage(s) to copy packages to a PPA, if they fail they currently fail silently. This is in part due to the code in PCJ.run() that captures CannotCopy exceptions and swallows them (it assumes that all failures have a DistroSeriesDifference).

What could happen is that this piece of code writes the CannotCopy text to the PCJ's metadata. Failed jobs could be displayed in the PPA page and then the failed job can be deleted when acknowledged by a PPA uploader.

Related branches

lp:~cjwatson/launchpad/show-failed-copies
j.c.sackett (community): Approve
Diff: 160 lines (+47/-9)
3 files modified
lib/lp/soyuz/interfaces/packagecopyjob.py (+6/-0)
lib/lp/soyuz/model/packagecopyjob.py (+25/-3)
lib/lp/soyuz/tests/test_packagecopyjob.py (+16/-6)
Julian Edwards (julian-edwards)
tags: added: ppa
Changed in launchpad:
status: New → Triaged
importance: Undecided → Low
tags: added: derivation
Revision history for this message
Colin Watson (cjwatson) wrote :

Raphaël seems to have fixed most of this in r14665, but it doesn't quite work yet because the exception is still swallowed.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r15620 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/15620>.

Changed in launchpad:
assignee: nobody → Colin Watson (cjwatson)
tags: added: qa-needstesting
Changed in launchpad:
status: Triaged → Fix Committed
Revision history for this message
Colin Watson (cjwatson) wrote :

This almost works, but not quite. Looking directly at the dogfood database I can see that the error message is written to the PCJ's json_data. Unfortunately, the job's status is COMPLETED rather than FAILED, so it does not get shown in Archive:+packages.

Since this is no worse than the previous situation, and since copying to a PPA is hidden behind a feature flag anyway, this is still qa-ok, but it's not a complete fix.

Changed in launchpad:
status: Fix Committed → In Progress
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Colin Watson (cjwatson) wrote :

My previous test was invalid because I mistakenly tried to copy to the primary archive rather than a PPA. When I fixed my test to copy to a PPA instead, it all works fine. See attached screenshot.

Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
Julian Edwards (julian-edwards) wrote :

Awesome! What happens if there's multiple failed jobs?

Revision history for this message
Colin Watson (cjwatson) wrote : Re: [Bug 812869] Re: Failed PackageCopyJobs should show up on the PPA page somehow

On Mon, Jul 16, 2012 at 02:25:44AM -0000, Julian Edwards wrote:
> Awesome! What happens if there's multiple failed jobs?

Then you just get more of the same PendingCopyJob widgets immediately
underneath the first. (That's all Raphaël's work - I just finished
hooking it up.) I only tested up to two, but it seemed to work the way
I'd expect.

Martin Packman (gz)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.