lava_test_run will always pass
Bug #813919 reported by
Spring Zhang
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| LAVA Dispatcher |
Fix Released
|
Medium
|
Spring Zhang | ||
Bug Description
When lava-test fails to install, lava_test_run should fail but it will pass. Need to add some examination characters to determine if the test passes.
root@linaro:~# lava-test run stream -o /lava/results/
lava-test run stream -o /lava/results/
-bash: lava-test: command not found
Related branches
lp:~qzhang/lava-dispatcher/fix-813919
- Spring Zhang (community): Needs Resubmitting
-
Diff: 78 lines (+29/-8)2 files modifiedlava_dispatcher/actions/lava-test.py (+7/-5)
lava_dispatcher/client.py (+22/-3)
| Changed in lava-dispatcher: | |
| importance: | Undecided → Medium |
Revision history for this message
| Paul Larson (pwlars) wrote | #1 |
| Changed in lava-dispatcher: | |
| milestone: | none → 2011.08 |
| Changed in lava-dispatcher: | |
| assignee: | nobody → Spring Zhang (qzhang) |
Revision history for this message
| Spring Zhang (qzhang) wrote | #2 |
Revision history for this message
| Spring Zhang (qzhang) wrote | #3 |
| Changed in lava-dispatcher: | |
| milestone: | 2011.08 → 2011.09 |
| Changed in lava-dispatcher: | |
| status: | New → In Progress |
| Changed in lava-dispatcher: | |
| status: | In Progress → Fix Committed |
| Changed in lava-dispatcher: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
So there's two problems there then... we don't detect the failure in lava_test_install, and we don't do the same in lava_test_run. We should try to determine the exit status of the previous command, and use that to determine if something went wrong. Maybe we could add it to the prompt, and pick it up from there?