Allow for ClieOp export with empty reference
Bug #814009 reported by
Stefan Rijnhart (Opener)
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Account Banking Framework |
New
|
Undecided
|
Unassigned | ||
Bug Description
The current version of ABF does not seem to allow for ClieOp exports with empty reference. This is important, because several banks (Triodos, and according to their own specifications ING as well) do not accept ClieOp files with variant code C.
When we clear the reference field in the clieop wizard, an error occurs
File "convert.py", line 56, in to_swift
astr = unicode(astr, scheme)
TypeError: coercing to Unicode: need string or buffer, bool found
This can be avoided by initializing the SWIFTFields sender_id and batch_id with the empty string in case of a False value.
Also, the batch_id is taken from the original payment order reference instead of the wizard form values.
Cheers,
Stefan.
Related branches
lp:~therp-nl/account-banking/upgrade-6.0
- Stefan Rijnhart (Opener) (community): Needs Resubmitting
- Pieter J. Kersten (EduSense BV): Needs Fixing
-
Diff: 3078 lines (+1102/-1099) (has conflicts)32 files modifiedTHIS_BRANCH_IS_DEPRECATED.txt (+3/-0)
account_banking/__terp__.py (+3/-55)
account_banking/account_banking.py (+260/-269)
account_banking/account_banking_import_wizard.xml (+0/-15)
account_banking/account_banking_payment_wizard.xml (+0/-22)
account_banking/account_banking_view.xml (+106/-18)
account_banking/data/account_banking_data.xml (+2/-2)
account_banking/security/ir.model.access.csv (+2/-0)
account_banking/wizard/__init__.py (+1/-1)
account_banking/wizard/account_payment_order.py (+113/-0)
account_banking/wizard/bank_import.py (+149/-137)
account_banking/wizard/bank_import_view.xml (+52/-0)
account_banking/wizard/banktools.py (+24/-16)
account_banking/wizard/wizard_payment_order.py (+0/-212)
account_banking_fi_patu/__terp__.py (+2/-3)
account_banking_nl_abnamro/__openerp__.py (+2/-8)
account_banking_nl_abnamro/__terp__.py (+2/-8)
account_banking_nl_clieop/__terp__.py (+8/-6)
account_banking_nl_clieop/account_banking_export_wizard.xml (+0/-15)
account_banking_nl_clieop/account_banking_nl_clieop.py (+7/-13)
account_banking_nl_clieop/account_banking_nl_clieop.xml (+36/-13)
account_banking_nl_clieop/data/banking_export_clieop.xml (+9/-3)
account_banking_nl_clieop/migrations/0.63/post-fill-ir_model_id.py (+44/-0)
account_banking_nl_clieop/security/ir.model.access.csv (+2/-0)
account_banking_nl_clieop/wizard/clieop.py (+2/-2)
account_banking_nl_clieop/wizard/export_clieop.py (+204/-249)
account_banking_nl_clieop/wizard/export_clieop_view.xml (+58/-0)
account_banking_nl_girotel/__terp__.py (+2/-3)
account_banking_nl_multibank/__terp__.py (+2/-3)
account_banking_nl_triodos/__openerp__.py (+2/-13)
account_banking_nl_triodos/__terp__.py (+2/-13)
account_banking_nl_triodos/triodos.py (+3/-0)
To post a comment you must log in.
