Remove stub_network flag and replace usage with stubbing out of relevant calls in tests

Bug #816025 reported by Vish Ishaya
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Rongze Zhu

Bug Description

We have FLAGS.stub_network to ignore some code paths in tests. This mixing should be removed in favor of stubs in the tests themselves.

Changed in nova:
status: New → Triaged
importance: Undecided → Low
Tom Fifield (fifieldt)
tags: added: low-hanging-fruit
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/11619

Changed in nova:
assignee: nobody → Rongze Zhu (zrzhit)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/11619
Committed: http://github.com/openstack/nova/commit/3313cffde85a9f02d56f57b401c2aec5b91d6df8
Submitter: Jenkins
Branch: master

commit 3313cffde85a9f02d56f57b401c2aec5b91d6df8
Author: Rongze Zhu <email address hidden>
Date: Sun Aug 19 07:25:06 2012 +0000

    Remove stub_network flag

    Fixes bug #816025

    remove stub_network flag and replace usage with stubbing out of relevant
    calls in tests.
    In nova/tests/fake_network.py , I add set_stub_network_methods and
    unset_stub_network_methods. They can be userd for tests.

    Change-Id: Ie8fa95d9ab62cced00f0917cffe75ebc6c94bb3e

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → folsom-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-rc1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.