Improve pylint score
Bug #822813 reported by
Salvatore Orlando
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| neutron |
Invalid
|
Medium
|
Unassigned | ||
Bug Description
pylint job on jenkins reveals 32 files have violations, for a staggering total of 734 violations!
Nova, which is a lot larger than Quantum, has 4720 violations.
Achieving a pylint score of 8/10 would be a good result.
Related branches
lp:~salvatore-orlando/neutron/bug822813
- Somik Behera: Needs Fixing (netstack-core)
- Tyler Smith: Approve
-
Diff: 2096 lines (+362/-265)35 files modifiedquantum/api/api_common.py (+5/-0)
quantum/api/attachments.py (+22/-18)
quantum/api/networks.py (+21/-10)
quantum/api/ports.py (+29/-25)
quantum/cli_lib.py (+53/-11)
quantum/client.py (+20/-16)
quantum/common/config.py (+2/-5)
quantum/common/exceptions.py (+29/-4)
quantum/common/extensions.py (+50/-7)
quantum/common/test_lib.py (+5/-6)
quantum/common/utils.py (+5/-6)
quantum/db/api.py (+25/-23)
quantum/manager.py (+1/-1)
quantum/plugins/SamplePlugin.py (+40/-23)
quantum/plugins/cisco/common/cisco_credentials.py (+2/-2)
quantum/plugins/cisco/common/cisco_utils.py (+1/-2)
quantum/plugins/cisco/conf/db_conn.ini (+3/-3)
quantum/plugins/cisco/conf/plugins.ini (+1/-1)
quantum/plugins/cisco/db/api.py (+1/-17)
quantum/plugins/cisco/db/l2network_db.py (+0/-2)
quantum/plugins/cisco/l2network_plugin.py (+26/-27)
quantum/plugins/cisco/models/l2network_multi_blade.py (+0/-3)
quantum/plugins/cisco/models/l2network_single_blade.py (+0/-3)
quantum/plugins/cisco/run_tests.py (+1/-4)
quantum/plugins/cisco/tests/unit/test_database.py (+9/-9)
quantum/plugins/cisco/ucs/cisco_ucs_inventory.py (+4/-5)
quantum/plugins/cisco/ucs/cisco_ucs_network_driver.py (+0/-2)
quantum/plugins/cisco/ucs/cisco_ucs_plugin.py (+1/-2)
quantum/plugins/openvswitch/ovs_db.py (+0/-1)
quantum/plugins/openvswitch/ovs_models.py (+1/-5)
quantum/plugins/openvswitch/ovs_quantum_plugin.py (+1/-3)
quantum/plugins/openvswitch/run_tests.py (+0/-4)
quantum/service.py (+3/-3)
quantum/utils.py (+0/-11)
tests/unit/test_cli.py (+1/-1)
| Changed in quantum: | |
| importance: | Undecided → Low |
| assignee: | nobody → Salvatore Orlando (salvatore-orlando) |
| status: | New → In Progress |
| milestone: | none → diablo-integration-freeze |
| Changed in quantum: | |
| milestone: | diablo-rbp → none |
Revision history for this message
| dan wendlandt (danwent) wrote | #1 |
| Changed in quantum: | |
| importance: | Low → Medium |
Revision history for this message
| Salvatore Orlando (salvatore-orlando) wrote | #2 |
| Changed in quantum: | |
| assignee: | Salvatore Orlando (salvatore-orlando) → nobody |
Revision history for this message
| Maru Newby (maru) wrote | #3 |
Revision history for this message
| dan wendlandt (danwent) wrote Re: [Bug 822813] Re: Improve pylint score | #4 |
Revision history for this message
| Maru Newby (maru) wrote | #5 |
| Changed in quantum: | |
| status: | In Progress → Confirmed |
Revision history for this message
| Gary Kotton (garyk) wrote | #6 |
| Changed in quantum: | |
| status: | Confirmed → Invalid |
To post a comment you must log in.
This work got abandoned, which is really too bad. I doubt a patch would apply cleanly now, and I do have some concerns about replacing "Exception" with "QuantumException" (since this could change behavior), but I would like to look into keeping a lot of these changes. Perhaps I will get a beer and copy/paste these changes at some point :)
I think we will want to do a pylint/code coverage push early E-4 in prep for our proposal as a "core" project for "F".