Odoo Server (MOVED TO GITHUB)

[export/import] fail to import boolean with False value

Bug #831009 reported by tfr (Openerp) on 2011-08-22

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Odoo Server (MOVED TO GITHUB)	Fix Released	Low	OpenERP's Framework R&D

how to reproduce :
-export a partner with supplier and customer False, (export dbname also)
got a file like this
"name",".id","customer","supplier"

"OpenERP S.A.","1","",""

-Change value of supplier and customer to True
-Save
-Import the previous File => supplier and customer should be set to false.
-But it doesn't

Import this file
"name","customer","supplier",".id"

"OpenERP S.A.","False","False","1"

It works

Merged into lp:openobject-server at revision 3603

Vo Minh Thu: Pending requested 2011-08-23

Revision history for this message

tfr (Openerp) (tfr) wrote on 2011-08-22:

Not updating data when the field value is '' not a bad practice but
When a boolean field is export should always be "True" or "False" not ""

Revision history for this message

tfr (Openerp) (tfr) wrote on 2011-08-22:

I suggest this one line patch

Dhruti Shastri(OpenERP) (dhs-openerp) on 2011-08-23

Changed in openobject-server:
assignee:	nobody → OpenERP's Framework R&D (openerp-dev-framework)
importance:	Undecided → Low
status:	New → Confirmed

Revision history for this message

Naresh(OpenERP) (nch-openerp) wrote on 2011-08-23:

Hello tfr,

Thanks for the patch tfr. The patch seems ok, we have converted the patch to a merge proposal with the commit authored to you @lp:~openerp-dev/openobject-server/trunk-bug-831009-nch

This will be reviewed and merged soon to the trunk.

Thanks,