[MIR] gaupol (translate-toolkit Recommends python-aeidon)

Bug #834442 reported by Matthias Klose
20
This bug affects 3 people
Affects Status Importance Assigned to Milestone
translate-toolkit (Ubuntu)
Won't Fix
High
Unassigned
Oneiric
Won't Fix
High
Unassigned

Bug Description

libreoffice pulls in translate-toolkit into main, but doesn't export translations anymore.

the b-d should be removed, or the following component mismatch (including further dependencies) should be addressed, and this report converted to a MIR.

Source and binary promotions to main
 ------------------------------------

 o gaupol: python-aeidon
   [Reverse-Recommends: translate-toolkit]

Matthias Klose (doko)
Changed in libreoffice (Ubuntu Oneiric):
assignee: nobody → Canonical Desktop Team (canonical-desktop-team)
importance: Undecided → High
milestone: none → ubuntu-11.10-beta-1
status: New → Confirmed
Martin Pitt (pitti)
Changed in libreoffice (Ubuntu Oneiric):
assignee: Canonical Desktop Team (canonical-desktop-team) → Björn Michaelsen (bjoern-michaelsen)
Martin Pitt (pitti)
Changed in libreoffice (Ubuntu):
milestone: ubuntu-11.10-beta-1 → ubuntu-11.10-beta-2
tags: added: rls-mgr-o-tracking
Brad Figg (brad-figg)
tags: removed: rls-mgr-o-tracking
Revision history for this message
Björn Michaelsen (bjoern-michaelsen) wrote :

translate-toolkit is still needed for po2sdf conversion in the build. demoting the recommends to a suggests is the way to go.

Brad Figg (brad-figg)
tags: added: rls-mgr-o-tracking
Revision history for this message
Björn Michaelsen (bjoern-michaelsen) wrote : Re: [MIR] translate-toolkit

Created translate-toolkit-1.9.0-1ubuntu1 demoting python-aeidon from recommends to suggests.

MIR rationale: needed for Libreoffice as build depend and is getting used by Libreoffice upstream.

summary: - libreoffice pulls in translate-toolkit into main, but doesn't export
- translations anymore
+ [MIR] translate-toolkit
Changed in libreoffice (Ubuntu Oneiric):
assignee: Björn Michaelsen (bjoern-michaelsen) → nobody
Michael Terry (mterry)
affects: libreoffice (Ubuntu Oneiric) → translate-toolkit (Ubuntu Oneiric)
Changed in translate-toolkit (Ubuntu Oneiric):
assignee: nobody → Michael Terry (mterry)
milestone: ubuntu-11.10-beta-2 → none
milestone: none → ubuntu-11.10-beta-2
Revision history for this message
Michael Terry (mterry) wrote :

Approved from a MIR/maintaining perspective. Assigning to ubuntu-security just for a quick check on tmserver, which seems like a potential concern, though there are no CVEs I could find and it doesn't seem to be automatically run.

Changed in translate-toolkit (Ubuntu Oneiric):
assignee: Michael Terry (mterry) → Ubuntu Security Team (ubuntu-security)
Changed in translate-toolkit (Ubuntu Oneiric):
assignee: Ubuntu Security Team (ubuntu-security) → Jamie Strandboge (jdstrand)
status: Confirmed → In Progress
Dave Walker (davewalker)
Changed in translate-toolkit (Ubuntu):
milestone: ubuntu-11.10-beta-2 → ubuntu-11.10
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

Security review for tmserver:
translate/services/tmserver.py uses a translate/misc/tmdb object and exposes it via a REST api. This api is defined in __init__() in tmserver.py, and exposes GET, POST, PUT and DELETE. Several of the defined methods are noops and worked as TODO. The api is simple, and arguments are sanitized. tmserver is resistant to SQL injection via its correct use of the python Cursor object and DB-API parameter substitution via tmdb.py. It also appears to be using the logging module correctly in misc/wsgi.py.

Beyond the coding of tmserver.py, there are a few issues:
- tmserver.py does not support SSL so server and client interactions can be MITMd
- there is no authentication built into tmserver.py
- the way misc/wsgi.py is coded, it will use try the following in order: cherrypy, werkzeug, django and finally wsgiref (part of python). Upstream doesn't appear too thrilled with wsgiref because "it doesn't support concurrency at all". I think the way that wsgi.py is coded makes maintenance difficult, as people may use different backends which may have different behaviors.

The MITM does not seem to be an issue for client to server communications, as the server is coded defensively (but obviously faulty data could be inserted into its sqlite database). server to client communications could be problematic depending on what the client is doing and whether or not it trusts the server. The rdepends of translate-toolkit are virtaal, pootle, and lokalize (all in universe). As pootle is a "Web-based translation and translation management tool", it may have tmserver support, but I did not check it. I don't think this is a blocker in general, as translate-toolkit does not ship an initscript for tmserver.py, it is not running after install and the manpage gives an example that uses an unprivileged port.

All that said, since libreoffice needs this, but it does not explicitly need tmserver, it would be preferred if tmserver was split out into it's own package and put in universe, or not shipped at all. Since this is extremely late in the Oneiric cycle, I do not hold out much hope for this....

Changed in translate-toolkit (Ubuntu Oneiric):
assignee: Jamie Strandboge (jdstrand) → nobody
status: In Progress → Confirmed
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

Per discussion on IRC (thanks slangasek!), translate-toolkit does not need the MIR review as it has been in main forever. gaupol needed the review (for translate-toolkit's Recommends on python-aeidon), but translate-toolkit was already adjusted for python-aeidon to Suggests. As such, this bug can now be closed.

summary: - [MIR] translate-toolkit
+ [MIR] gaupol (translate-toolkit Recommends python-aeidon)
Changed in translate-toolkit (Ubuntu Oneiric):
status: Confirmed → Won't Fix
Changed in translate-toolkit (Ubuntu):
milestone: ubuntu-11.10 → none
status: Confirmed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.