/+search, /products, /people, etc obscure search field and should have their own layout

Bug #84326 reported by Matthew Paul Thomas
22
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Matthew Paul Thomas

Bug Description

These pages should share a layout that does not have unclickable tabs:
<https://beta.launchpad.net/products>
<https://beta.launchpad.net/projects>
<https://beta.launchpad.net/people>
<https://beta.launchpad.net/distros>
This would also fix the problem where the global search field is partly hidden on these pages.

Similarly <https://beta.launchpad.net/+search?q=ubuntu> should have small application buttons, not large application buttons.

Changed in launchpad:
importance: Undecided → Medium
description: updated
Revision history for this message
Guilherme Salgado (salgado) wrote :

Does this mean these pages will have an icon like https://beta.launchpad.net/sprints does?

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

No, /sprints should not have an icon, context heading, *or* tabs. (Reported that as bug 86145.) So there needs to be a new template that includes the tabs but not the context heading.

Revision history for this message
Guilherme Salgado (salgado) wrote : Re: /+search, /products, /people, etc obscure search field and should have tabs

<https://beta.launchpad.net/projects> is the only one which is missing tabs.

<https://beta.launchpad.net/+search?q=ubuntu> still has the applications button, but the small ones now.

The other pages now have tabs *and* placeholder for icons, but we don't have the infrastructure to fill in those placeholders because the context in those pages are not one of our pillars and we don't seem to have a way to include the tabs but not the heading icon in a page.

Would it be okay to hack templates/launchpad-structuralheader.pt to not include the icon in these cases?
(Without this I can't land the final bits of PillarGotchis)

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Mark has redesigned these pages; they should now have application buttons, not tabs. Marking as Critical since it blocks your pillargotchi work.

Changed in launchpad:
assignee: nobody → mpt
importance: Medium → Critical
status: Unconfirmed → In Progress
description: updated
Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Fixed in RF 4011.

Changed in launchpad:
status: Fix Committed → Fix Released
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

This was fixed for 1.0, not 1.1.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.