kde keyboard: space to display variant name is too small
Bug #851160 reported by
Achim Bohnet
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubiquity (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
ubiquity kde frontend, keyboard selection form:
For languages with long translations for 'Layout' and 'Variant' and/or long country names, the horizontal layout has not enough room to display the often long names of a keyboard variant.
As it's late in the 'O' cycle I would suggest to place 'Layout' and 'Variant' vertically not horizontally as it is now. There much not used vertial space to allow this.
see qui/qt/
Related branches
lp:~agateau/ubiquity/fix-keyboard-variant-combobox
- Achim Bohnet (community): Approve (tested the patch)
- Ubuntu Installer Team: Pending requested
-
Diff: 78 lines (+8/-44)1 file modifiedgui/qt/stepKeyboardConf.ui (+8/-44)
To post a comment you must log in.
For 'P' cycle:
The variant name is also always prefixed with the layout name with makes it unnecessarily much longer. IMHO it would be worth to shorten it like:
=== modified file 'ubiquity/misc.py' 639_3_entry[ @part1_ code='% s']" gnome/periphera ls/keyboard/ kbd/layouts' variant( *args):
variants. append( '%s\t%s' % (args[1] .get_name( ), args[2] .get_name( ))) append( args[2] .get_name( ))
variants. append( args[1] .get_name( )) append( 'default' )
--- ubiquity/misc.py 2011-09-02 11:59:28 +0000
+++ ubiquity/misc.py 2011-09-13 19:54:11 +0000
@@ -573,11 +573,14 @@
xpath = "//iso_
gconf_key = '/desktop/
variants = []
+ shown_variants = []
def process_
if hasattr(args[2], 'get_name'):
+ shown_variants.
else:
+ shown_variants.
lang = locale. split(' _')[0] parseFile( '/usr/share/ xml/iso- codes/iso_ 639_3.xml' )
fp = libxml2.
Unsolved is when to use shown_variant and when variant later on in misc.py ;)
Achim