kde keyboard: space to display variant name is too small

Bug #851160 reported by Achim Bohnet
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubiquity (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

ubiquity kde frontend, keyboard selection form:

For languages with long translations for 'Layout' and 'Variant' and/or long country names, the horizontal layout has not enough room to display the often long names of a keyboard variant.

As it's late in the 'O' cycle I would suggest to place 'Layout' and 'Variant' vertically not horizontally as it is now. There much not used vertial space to allow this.

see qui/qt/stepKeyboardConf.ui

Related branches

Revision history for this message
Achim Bohnet (allee) wrote :
Revision history for this message
Achim Bohnet (allee) wrote :
Revision history for this message
Achim Bohnet (allee) wrote :

For 'P' cycle:

The variant name is also always prefixed with the layout name with makes it unnecessarily much longer. IMHO it would be worth to shorten it like:

=== modified file 'ubiquity/misc.py'
--- ubiquity/misc.py 2011-09-02 11:59:28 +0000
+++ ubiquity/misc.py 2011-09-13 19:54:11 +0000
@@ -573,11 +573,14 @@
     xpath = "//iso_639_3_entry[@part1_code='%s']"
     gconf_key = '/desktop/gnome/peripherals/keyboard/kbd/layouts'
     variants = []
+ shown_variants = []
     def process_variant(*args):
         if hasattr(args[2], 'get_name'):
             variants.append('%s\t%s' % (args[1].get_name(), args[2].get_name()))
+ shown_variants.append(args[2].get_name())
         else:
             variants.append(args[1].get_name())
+ shown_variants.append('default')

     lang = locale.split('_')[0]
     fp = libxml2.parseFile('/usr/share/xml/iso-codes/iso_639_3.xml')

Unsolved is when to use shown_variant and when variant later on in misc.py ;)

Achim

description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubiquity - 2.7.30

---------------
ubiquity (2.7.30) oneiric; urgency=low

  [ Harald Sitter ]
  * [KDE] Fix language selection comobox position within grid (LP: #743062)
  * [KDE] Make intro label miminum expanding, otherwise word wrap will not
    work for vast amounts of text

  [ Evan Dandrea ]
  * Unset UBUNTU_MENUPROXY so our custom panel doesn't lose its
    indicators (LP: #837287).
  * Port the panel to GTK3.
  * Manually connect the activate-link signal on the advanced
    partitioning tool link on the automatic partitioning page.
    GtkBuilder signal mapping appears to be broken (LP: #852054).
  * The first partitioning page does not translate its options ahead of
    time, so ensure that the placeholder text isn't so long as to create
    the installer window to grow excessively large before partitioning
    is reached (LP: #837406).
  * Use the new network-manager interface on the prepare page to disable
    options that need an Internet connection when one is not available
    (LP: #848938).
  * Update translations from Launchpad.
  * Automatic update of included source packages: flash-kernel
    2.28ubuntu33.

  [ Stéphane Graber ]
  * Change wallpaper C program to accept a path to a wallpaper as a parameter.
  * Update ubiquity-dm to set the right wallpaper for Edubuntu.
  * Fix ibus in Ubiquity (LP: #838850)

  [ Aurélien Gâteau ]
  * gui/qt/stepKeyboardConf.ui
   - Put keyboard variable combobox on separate line (LP: #851160)

  [ Jonathan Riddell ]
  * kde_ui.py
   - Fix breakage in debfilter crash dialogue
 -- Evan Dandrea <email address hidden> Mon, 19 Sep 2011 19:37:28 +0100

Changed in ubiquity (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.