Upload form not hidden correctly when selecting group files in a block
Bug #854369 reported by
Richard Mansfield
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mahara |
Fix Released
|
Low
|
Richard Mansfield | ||
Bug Description
When selecting files for a block, the filebrowser "owner" tabs (my files, group files, etc.) are supposed to determine whether the upload form is displayed.
However, when browsing group files, the tab upload rules are overridden by code to show/hide the upload form depending on the group folder permissions (introduced in commit 3ed6f3390c60de8
The problem is that the filebrowser javascript doesn't remember whether the currently selected tab allows uploads.
| Changed in mahara: | |
| status: | New → In Progress |
| importance: | Undecided → Low |
| assignee: | nobody → Richard Mansfield (richard-mansfield) |
| milestone: | none → 1.5.0 |
Revision history for this message
| Mahara Bot (dev-mahara) wrote A change has been merged | #1 |
| Changed in mahara: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Melissa Draper (melissa) wrote | #2 |
| Changed in mahara: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Reviewed: https:/
Committed: http://
Submitter: Richard Mansfield (<email address hidden>)
Branch: master
commit 0e1a0a2d2ea7c05
Author: Richard Mansfield <email address hidden>
Date: Tue Sep 20 14:13:34 2011 +1200
Hide upload form when group files tab disables it (bug #854369)
When selecting files for a block, the filebrowser "owner" tabs (my
files, group files, etc.) are supposed to determine whether the upload
form is displayed.
However, when browsing group files, the tab upload rules are
overridden by code introduced in commit 3ed6f3390c to show/hide the
upload form depending on the group folder permissions. So when
configuring a block within a personal view, the upload form should be
hidden when browsing group files, but it's not hidden when the user
has permission to edit the selected group folder.
This patch ensures the filebrowser js remembers the state of the
upload permission granted by the selected tab, and doesn't override
that status when changing to a folder with different group edit
permissions.
Change-Id: I673815e1717550
Signed-off-by: Richard Mansfield <email address hidden>