OpenStack Identity (keystone)

Typo error on /keystone/controllers/roles.py

Bug #859937 reported by Luis Gervaso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
Yogeshwar
OpenStack Identity (keystone) 2012.1 "essex"

Bug Description

In add_global_role_to_user,

return utils.send_result(201)

causes an exception

send_result() takes at least 2 arguments (1 given)

so it's necesary req parameter

Revision history for this message
sounghie (sounghie) wrote :

i'm solved same issue

/keystone/manage/api.py
---- orign source
@utils.wrap_error
def add_global_role_to_user(self, req, user_id, role_id):
        config.SERVICE.add_global_role_to_user(utils.get_auth_token(req),
            user_id, role_id)
       return utils.send_result(201)

---modified source
@utils.wrap_error
def add_global_role_to_user(self, req, user_id, role_id):
        rval = config.SERVICE.add_global_role_to_user(utils.get_auth_token(req),
            user_id, role_id)
       return utils.send_result(201, req, rval)

Revision history for this message
Yogeshwar (yogesh-srikrishnan) wrote :

Fixed the issue would soon be pushing the commit.

Changed in keystone:
status: New → In Progress
Yogeshwar (yogesh-srikrishnan)
Changed in keystone:
importance: Undecided → Medium
assignee: nobody → Yogeshwar (yogesh-srikrishnan)
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : A change has been merged to openstack/keystone

Reviewed: https://review.openstack.org/867
Committed: http://github.com/openstack/keystone/commit/8ff740d6b401094d618a70a327c4f4c1e4ad16e3
Submitter: Jenkins
Branch: master

 status fixcommitted
 done

commit 8ff740d6b401094d618a70a327c4f4c1e4ad16e3
Author: Yogeshwar Srikrishnan <email address hidden>
Date: Thu Oct 13 10:43:16 2011 -0500

     Fixing bug 859937.
     Removing incorrect atom feed references from roles.xsd.

    Change-Id: I3fabbf280c372bdd7cbc920adf62fabe7c292f58

Yogeshwar (yogesh-srikrishnan)
Changed in keystone:
status: In Progress → Fix Committed
Joe Savak (jsavak)
tags: added: diablo-backport
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to keystone (stable/diablo)

Reviewed: https://review.openstack.org/1337
Committed: http://github.com/openstack/keystone/commit/86eb9b06a172879c82b97284d85d5a7b8f6f1d27
Submitter: Jenkins
Branch: stable/diablo

 status fixcommitted
 done

commit 86eb9b06a172879c82b97284d85d5a7b8f6f1d27
Author: Yogeshwar Srikrishnan <email address hidden>
Date: Thu Oct 13 10:43:16 2011 -0500

     Fixing bug 859937.
     Removing incorrect atom feed references from roles.xsd.

    Change-Id: I3fabbf280c372bdd7cbc920adf62fabe7c292f58

Yogeshwar (yogesh-srikrishnan)
Changed in keystone:
milestone: none → essex-1
Thierry Carrez (ttx)
Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: essex-1 → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.