[SRU] /etc/init.d/smokeping does not create /var/run/smokeping

Bug #86212 reported by danb1974
14
Affects Status Importance Assigned to Milestone
smokeping (Ubuntu)
Fix Released
Undecided
Unassigned
Dapper
Fix Released
Medium
Unassigned
Edgy
Fix Released
Medium
Unassigned

Bug Description

Binary package hint: smokeping

Ubuntu 6.06 LTS

After system reboot smokeping does not start because /var/run/smokeping is no longer there and is not (re)created by smokeping init script.

TEST CASE:
Step to reproduce this issue:
1) install smokeping
2) Remove /var/run/smokeping directory
3) Run /etc/init.d/smokeping start (or restart)
Init script will raise an error since will be unable to locate /var/run/smokeping directory

Revision history for this message
Daniel T Chen (crimsun) wrote :

Fixed in Feisty already (2.0.9-2ubuntu1).

Changed in smokeping:
status: Unconfirmed → Fix Released
Revision history for this message
Daniel T Chen (crimsun) wrote :

dapper-updates SRU candidate.

Revision history for this message
Emmet Hikory (persia) wrote :

I've unsubscribed ubuntu-universe-sponsors, as there is nothing to sponsor. If a SRU candidate is prepared, please resubscribe for sponsorship.

Changed in smokeping:
importance: Undecided → Medium
status: Unconfirmed → Confirmed
Revision history for this message
Chris Samuel (chris-csamuel) wrote :

Given that this appears to be a simple one line patch to the init script, any clues on when this fix is likely to appear in Dapper ?

Revision history for this message
Chris Samuel (chris-csamuel) wrote :

Here is the patch that I've just done for work to fix this bug. Hope it helps!

Revision history for this message
Luca Falavigna (dktrkranz) wrote :

This bug affects Edgy too.

Chris, could you prepare two debdiffs for {dapper,edgy}-proposed for this bug? You may follow these guidelines: https://wiki.ubuntu.com/MOTU/SRU. If you need some help, I will be happy to guide you.

Changed in smokeping:
status: New → Confirmed
Revision history for this message
Lionel Porcheron (lionel.porcheron) wrote :

For the fix to be correct, you should test directory existance before trying to create it. The actual smokeping init script is a good sample :)

Revision history for this message
Lionel Porcheron (lionel.porcheron) wrote :

My bad, forget my last comment and please go on.

Revision history for this message
Chris Samuel (chris-csamuel) wrote :

Hi Luca,

I'm afraid I'm not a Debian packaging person, so asides from using make-kpkg to build newer kernel releases for better power saving for Gutsy I've no real experience to go on. Work keeps me busy enough as it is (and my home systems all run Gutsy)!

I'll see if I can persuade the DD who works for me to look into fixing this for Dapper.

We don't have any edgy boxes left I'm afraid.

Revision history for this message
Luca Falavigna (dktrkranz) wrote :

Whoa! A DD just for you! Where I can hire one? :)
Anyway, if you have not time or boxes to test the fixes, I can handle them easily. Just let me know.

Emmet Hikory (persia)
Changed in smokeping:
importance: Undecided → Medium
Changed in smokeping:
assignee: nobody → dktrkranz
status: Confirmed → In Progress
assignee: nobody → dktrkranz
status: Confirmed → In Progress
Revision history for this message
Luca Falavigna (dktrkranz) wrote :

Debdiff for dapper-proposed.

Changed in smokeping:
assignee: dktrkranz → nobody
status: In Progress → Confirmed
Revision history for this message
Luca Falavigna (dktrkranz) wrote :

Debdiff for edgy-proposed.

Changed in smokeping:
assignee: dktrkranz → nobody
status: In Progress → Confirmed
description: updated
Revision history for this message
Luca Falavigna (dktrkranz) wrote :

Uploaded to {dapper,edgy}-proposed.

Revision history for this message
Martin Pitt (pitti) wrote :

Accepted into dapper-proposed, please test.

Changed in smokeping:
status: Confirmed → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote :

Accepted into edgy-proposed, please test.

Changed in smokeping:
status: Confirmed → Fix Committed
Revision history for this message
Daniel Schwitzgebel (schwitzd) wrote :

for me work on dapper and edgy

Revision history for this message
Salvatore Palma (palma-salvatore) wrote :

for me work on edgy and feisty

Revision history for this message
Salvatore Palma (palma-salvatore) wrote :

for me work on dapper

Revision history for this message
Luca Falavigna (dktrkranz) wrote :

Minimum aging period of seven days elapsed and two persons confimed fix is good.
Tagging verification-motu-done as per http://wiki.ubuntu.com/StableReleaseUpdates (previous policy)

Revision history for this message
Martin Pitt (pitti) wrote :

Copied to dapper/edgy-updates.

Changed in smokeping:
status: Fix Committed → Fix Released
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.