ProcEnviron should include DISPLAY among other things

We can infer from ProcMaps when LD_* libraries were used to load libraries from e. g. /usr/local or /home. The generic hook already does that check and tags a bug with "local-libs" if that happens:

------------------ 8< --------------------
    # using local libraries?
    if 'ProcMaps' in report:
        local_libs = set()
        for lib in re.finditer(r'\s(/[^ ]+\.so[.0-9]*)$', report['ProcMaps'], re.M):
            if not apport.fileutils.likely_packaged(lib.group(1)):
                local_libs.add(lib.group(1))
        if local_libs:
            if not ui.yesno('''The crashed program seems to use third-party or local libraries:

%s

It is highly recommended to check if the problem persists without those first.

Do you want to continue the report process anyway?
''' % '\n'.join(local_libs)):
                raise StopIteration
            report['LocalLibraries'] = ' '.join(local_libs)
            report['Tags'] = (report.get('Tags', '') + ' local-libs').strip()
------------------ 8< --------------------

Is that sufficient for your purpose?

What do you want to get out of $DISPLAY, just knowing that it's set? The particular value probably isn't very interesting?

Yes, just knowing that it is set should be sufficient. This came up because of bug 848915 and here is some discussion around it.

08:50 < mvo> cjwatson: this sounds like DISPLAY is not set
08:50 < cjwatson> hm, you've commented I see
08:51 -!- robbiew [~RobbieWil@99-156-84-159.lightspeed.austtx.sbcglobal.net] has joined #ubuntu-meeting
08:51 < mvo> cjwatson: this was the only way I managed to reproduce
08:51 < cjwatson> distinctly odd since the reporters seem to be using the GTK frontend though
08:51 < bdmurray> duplicate bug 867629 has a test case
08:51 < ubottu> Launchpad bug 848915 in update-manager (Ubuntu Oneiric) "duplicate for #867629 update-manager crashed with RuntimeError in /usr/lib/python2.7/dist-packages/gi/overrides/Gtk.py: Gtk couldn't be initialized" [High,Incomplete] https://launchpad.net/bugs/848915
08:51 < cjwatson> surely they couldn't have got that far ...
08:51 < mvo> bdmurray: oh, nice!
08:52 < mvo> bdmurray: gksu then most likely
08:53 < cjwatson> yeah, gksu will be sanitising the environment
08:53 < slangasek> yeah, why would gksu need DISPLAY...
08:53 < slangasek> :)
08:55 -!- laoshi [~flemming@85.218.199.31] has quit [Remote host closed the connection]
08:55 < slangasek> someone's triaging that one to gksu then? someone want to work on it?
08:55 < jhunt> bdmurray, cjwatson, mvo: maybe apport could be changed to include DISPLAY in 'ProcEnviron'?

[Expired for apport (Ubuntu) because there has been no activity for 60 days.]

This release of Ubuntu is no longer receiving maintenance updates. If this is still an issue on a maintained version of Ubuntu please let us know.

[Expired for apport (Ubuntu) because there has been no activity for 60 days.]