cgroup-bin upstart job does not handle the package being removed but not purged properly

Hi Clint,

is it really valid to require an upstart job for package X to check that other scripts installed by package X are in fact installed?

If so this is trivial to add, but it seems over the top to worry about the upstart job failing (with no further ill effects on the host, IIUC) if the package is in a bad state. Put another way, you say the upstart job should 'exit gracefully', but really the upstart job should fail under this condition!

(Or have I misunderstood the scenario?)

Excerpts from Serge Hallyn's message of Wed Oct 19 18:38:35 UTC 2011:
> Hi Clint,
>
> is it really valid to require an upstart job for package X to check that
> other scripts installed by package X are in fact installed?
>
> If so this is trivial to add, but it seems over the top to worry about
> the upstart job failing (with no further ill effects on the host, IIUC)
> if the package is in a bad state. Put another way, you say the upstart
> job should 'exit gracefully', but really the upstart job should fail
> under this condition!
>

Its required by policy. Upstart jobs are conffiles, and so are not
removed until a package is *purged*.. even though the binaries are.

Jinkeys, so they are. Thanks.

@Clint,

Note that I don't see any other upstart jobs (ssh, libvirt-bin, etc) doing this.

For cgroup-bin, just to make sure I'm understanding right, should it do 'stop; exit 0;' if the binary is not found?

Excerpts from Serge Hallyn's message of Thu Oct 20 13:40:04 UTC 2011:
> @Clint,
>
> Note that I don't see any other upstart jobs (ssh, libvirt-bin, etc)
> doing this.
>
> For cgroup-bin, just to make sure I'm understanding right, should it do
> 'stop; exit 0;' if the binary is not found?

Err, are you sure ssh doesn't do it?

    test -x /usr/sbin/sshd || { stop; exit 0; }

Thats the first line of the pre-start of ssh.conf. Should do a similar
thing with cgconfigparser.

This bug was fixed in the package libcgroup - 0.37.1-1ubuntu9

---------------
libcgroup (0.37.1-1ubuntu9) precise; urgency=low

  * Don't run upstart jobs if package has been removed but not purged.
    (LP: #875525)
 -- Serge Hallyn <email address hidden> Wed, 04 Jan 2012 11:11:19 -0600