OpenStack Core Infrastructure

Bug should not be set to FixCommitted on non-master merge

Bug #888479 reported by Thierry Carrez
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Core Infrastructure
Fix Released
High
Thierry Carrez

Bug Description

Currently a merge in any branch triggers a FixCommitted status change. It should only do that for master: you don't want a bug to be closed when it's not fixed on master.

(Ideally, Gerrit would flag bugs that are committed in stable/diablo but that are not fixcommitted (fixed in master) already -- we can probably do that by hand by tagging "in-BRANCHNAME" bugs that were fixed in a specific branch and then looking for non-fixcommitted-bugs that are tagged in-stable-diablo)

Revision history for this message
Thierry Carrez (ttx) wrote :

https://review.openstack.org/1493

Changed in openstack-ci:
assignee: nobody → Thierry Carrez (ttx)
status: New → In Progress
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to openstack-ci-puppet (master)

Reviewed: https://review.openstack.org/1493
Committed: http://github.com/openstack/openstack-ci-puppet/commit/fa41ae0c0bfc99cd0cb3d08b85b17d91ede382cc
Submitter: Jenkins
Branch: master

 status fixcommitted
 done

commit fa41ae0c0bfc99cd0cb3d08b85b17d91ede382cc
Author: Thierry Carrez <email address hidden>
Date: Thu Nov 10 12:02:03 2011 +0100

    Only master merges set bugs to FixCommitted

    Fix bug 888479:
    Only allow master branch merges to set bug status to FixCommitted.
    For other branches (think stable/diablo or milestone-proposed), set
    a in-BRANCHNAME tag instead, to allow for efficient searching.

    Change-Id: I6401ab4ba92f7983040ac8b2008c88490e2589d8

Changed in openstack-ci:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in openstack-ci:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.