Mahara

Change ensure_sanity to check for PHP 5.3+ instead of 5.2+

Bug #890045 reported by Hugh Davenport
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Hugh Davenport
Mahara 1.5.0
Declined for 1.4 by François Marier
Declined for 1.5 by François Marier

Bug Description

Mahara requires PHP 5.3 and above to function (https://wiki.mahara.org/index.php/System_Administrator%27s_Guide/Installing_Mahara#Software and https://wiki.mahara.org/index.php/System_Administrator%27s_Guide/Requirements#PHP)

Also, PHP has issued an end-of-life statement for 5.2 (http://www.php.net/archive/2010.php#id2010-12-16-1)

At the moment, the check is done in the ensure_sanity function (lib/mahara.php line 37-41 on master).

This checks whether the version is 5.2 or above. It should check if it is 5.3 and above instead.

Revision history for this message
Hugh Davenport (hugh-davenport) wrote :

https://reviews.mahara.org/851

Changed in mahara:
status: New → Triaged
importance: Undecided → Medium
assignee: nobody → Hugh Davenport (hugh-catalyst)
status: Triaged → In Progress
Revision history for this message
Hugh Davenport (hugh-davenport) wrote :

After this dependency is lifted, we can most likely remove a lot of redundant checks, below is a comment from the review.

"If we require 5.3, there are probably a bunch of things we can clean up. Maybe we can assume fileinfo is around & remove the fallback to mime_content_type(). Aren't we also supposed to start getting rid of calls to split()?"

Revision history for this message
Hugh Davenport (hugh-davenport) wrote :

Also thought this would be good for 1.4.2 as well.

https://reviews.mahara.org/861

Changed in mahara:
milestone: none → 1.5.0
milestone: 1.5.0 → 1.4.2
milestone: 1.4.2 → 1.5.0
Revision history for this message
Hugh Davenport (hugh-davenport) wrote :

Scratch the 1.4.2, 1.4 is already released so shouldn't be changing requirements for point releases

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/851
Committed: http://gitorious.org/mahara/mahara/commit/21d5ea38a58e7d0672e716c61774c5672f216503
Submitter: Francois Marier (<email address hidden>)
Branch: master

commit 21d5ea38a58e7d0672e716c61774c5672f216503
Author: Hugh Davenport <email address hidden>
Date: Mon Nov 14 15:29:05 2011 +1300

    Change PHP requirement to 5.3+ (Bug #890045)

    Change-Id: I35d399d828d99dc3159928d7f19ba15b4a702916
    Signed-off-by: Hugh Davenport <email address hidden>

François Marier (fmarier)
Changed in mahara:
status: In Progress → Fix Committed
Melissa Draper (melissa)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.