OpenStack Identity (keystone)

Missing files from tarball due to incomplete MANIFEST.in

Bug #891093 reported by Thierry Carrez
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
High
Dolph Mathews
OpenStack Identity (keystone) 2012.1 "essex"

Bug Description

This was found while testing the tarball built using python setup.py sdist in preparation for 2011.3.1 "Diablo+" tarball cut.
The following files are missing from the tarball:

-AUTHORS
-bin/sampledata
-examples/echo/bin/
-examples/echo/bin/echod
-examples/echo/docs/
-examples/echo/docs/echo_flow.pdf
-examples/echo/docs/echo_flow.sdx
-examples/echo/echo/echo_basic.ini
-examples/echo/echo/echo.ini
-examples/echo/echo/echo_remote.ini
-examples/echo/echo/echo.wadl
-examples/echo/echo/samples/
-examples/echo/echo/samples/echo.json
-examples/echo/echo/samples/echo.xml
-examples/echo/echo/xsd/
-examples/echo/echo/xsd/echo.xsd
-examples/echo/echo/xsl/
-examples/echo/echo/xsl/echo.xsl
-examples/paste/
-examples/paste/auth_basic.ini
-examples/paste/auth_token.ini
-examples/paste/glance-api.conf
-examples/paste/glance-registry.conf
-examples/paste/nova-api-paste.ini
-examples/README.md
-HACKING
-keystone/backends/sqlalchemy/migrate_repo/migrate.cfg
-keystone/backends/sqlalchemy/migrate_repo/README
-keystone/contrib/extensions/admin/osec2/extension.json
-keystone/contrib/extensions/admin/osec2/extension.xml
-keystone/contrib/extensions/admin/osksadm/extension.json
-keystone/contrib/extensions/admin/osksadm/extension.xml
-keystone/contrib/extensions/admin/oskscatalog/extension.json
-keystone/contrib/extensions/admin/oskscatalog/extension.xml
-keystone/contrib/extensions/admin/raxgrp/
-keystone/contrib/extensions/admin/raxgrp/extension.json
-keystone/contrib/extensions/admin/raxgrp/extension.xml
-keystone/contrib/extensions/admin/raxkey/extension.json
-keystone/contrib/extensions/admin/raxkey/extension.xml
-keystone/contrib/extensions/service/osec2/extension.json
-keystone/contrib/extensions/service/osec2/extension.xml
-keystone/contrib/extensions/service/raxgrp/extension.json
-keystone/contrib/extensions/service/raxgrp/extension.xml
-keystone/contrib/extensions/service/raxkey/extension.json
-keystone/contrib/extensions/service/raxkey/extension.xml
-LICENSE
-.pylintrc

Please fix MANIFEST.in to include the missing files -- or remove them from repo if they are superfluous.

For this last file (.pylintrc) it is shipped as "pylintrc" (without the .) in other projects. I think it's good to not copy dotfiles from repo to tarball, so maybe it's better to rename it to pylintrc ?

Thierry Carrez (ttx)
tags: added: diablo-backport
Revision history for this message
Dolph Mathews (dolph) wrote :

I'm in favor of renaming .pylintrc to pylintrc, if nothing else, because no one can ever find our pylint settings :)

Changed in keystone:
assignee: nobody → Dolph Mathews (dolph)
status: Triaged → In Progress
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/1682
Committed: http://github.com/openstack/keystone/commit/fc84e174a2fc127d5a6a21a63e9c4d574c3b4ff7
Submitter: Jenkins
Branch: master

 status fixcommitted
 done

commit fc84e174a2fc127d5a6a21a63e9c4d574c3b4ff7
Author: Dolph Mathews <email address hidden>
Date: Wed Nov 16 08:26:14 2011 -0800

    Simplified gitignore (in pursuit of bug 891093)

    - Added dist/ (setup.py sdist output)
    - Assumed we never want to track any *.db files

    Change-Id: I5b59e55064ad2abc315790512c2b87c8cc4704c9

Changed in keystone:
status: In Progress → Fix Committed
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote :

Reviewed: https://review.openstack.org/1683
Committed: http://github.com/openstack/keystone/commit/d63247e10f36dbb7feb13c6ceae096b651321cc3
Submitter: Jenkins
Branch: master

 status fixcommitted
 done

commit d63247e10f36dbb7feb13c6ceae096b651321cc3
Author: Dolph Mathews <email address hidden>
Date: Wed Nov 16 08:30:17 2011 -0800

    pylintrc should not be hidden (bug 891093)

    Change-Id: Ifa7e22b31dd852eecfa3a546fdb8fa30ea96337f

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote :

Reviewed: https://review.openstack.org/1690
Committed: http://github.com/openstack/keystone/commit/0a674282dc8ad6037743d8906f22274a1e4c81bd
Submitter: Jenkins
Branch: master

 status fixcommitted
 done

commit 0a674282dc8ad6037743d8906f22274a1e4c81bd
Author: Dolph Mathews <email address hidden>
Date: Wed Nov 16 09:37:26 2011 -0800

    Added files missing from dist packaging (bug 891093)

    Change-Id: Ic515db5e3392a4eda18d3791fd0e2a6990b42efd

Revision history for this message
Thierry Carrez (ttx) wrote :
Download full text (3.8 KiB)

Master is apparently still missing a few files, is it all on purpose ?

-doc/design/flow_diagram.sdx
-doc/design/keystone-service-registration.sdx
-examples/echo/docs/echo_flow.sdx
-keystone/content/admin/identityadminguide.pdf
-keystone/content/admin/identity-admin.wadl
-keystone/content/admin/OS-KSADM-admin-devguide.pdf
-keystone/content/admin/OS-KSADM-admin.wadl
-keystone/content/admin/OS-KSCATALOG-admin-devguide.pdf
-keystone/content/admin/OS-KSCATALOG-admin.wadl
-keystone/content/admin/OS-KSEC2-admin-devguide.pdf
-keystone/content/admin/OS-KSEC2-admin.wadl
-keystone/content/admin/RAX-KSGRP-admin.wadl
-keystone/content/admin/RAX-KSKEY-admin-devguide.pdf
-keystone/content/admin/RAX-KSKEY-admin.wadl
-keystone/content/admin/RAX-KSQA-admin.wadl
-keystone/content/admin/version.json.tpl
-keystone/content/admin/version.xml.tpl
-keystone/content/common/common.ent
-keystone/content/common/js/
-keystone/content/common/js/shjs/
-keystone/content/common/js/shjs/sh_java.js
-keystone/content/common/js/shjs/sh_javascript.js
-keystone/content/common/js/shjs/sh_main.js
-keystone/content/common/js/shjs/sh_xml.js
-keystone/content/common/js/trc/
-keystone/content/common/js/trc/schema/
-keystone/content/common/js/trc/schema/controller.js
-keystone/content/common/js/trc/schema/layoutManager.js
-keystone/content/common/js/trc/schema/sampleManager.js
-keystone/content/common/js/trc/util.js
-keystone/content/common/samples/norequestbody.txt
-keystone/content/common/samples/noresponsebody.txt
-keystone/content/common/samples/samplerequestheader.txt
-keystone/content/common/samples/sampleresponseheader.txt
-keystone/content/common/samples/tenants-request.txt
-keystone/content/common/style/
-keystone/content/common/style/schema.css
-keystone/content/common/style/shjs/
-keystone/content/common/style/shjs/sh_acid.css
-keystone/content/common/style/shjs/sh_darkblue.css
-keystone/content/common/style/shjs/sh_emacs.css
-keystone/content/common/style/shjs/sh_night.css
-keystone/content/common/style/shjs/sh_pablo.css
-keystone/content/common/style/shjs/sh_print.css
-keystone/content/common/style/shjs/sh_style.css
-keystone/content/common/style/shjs/sh_whitengrey.css
-keystone/content/common/xsd/
-keystone/content/common/xsd/api-common.xsd
-keystone/content/common/xsd/api.xsd
-keystone/content/common/xsd/atom/
-keystone/content/common/xsd/atom/atom.xsd
-keystone/content/common/xsd/atom/xml.xsd
-keystone/content/common/xsd/credentials.xsd
-keystone/content/common/xsd/endpoints.xsd
-keystone/content/common/xsd/extensions.xsd
-keystone/content/common/xsd/fault.xsd
-keystone/content/common/xsd/OS-KSADM.xsd
-keystone/content/common/xsd/OS-KSCATALOG.xsd
-keystone/content/common/xsd/OS-KSEC2-credentials.xsd
-keystone/content/common/xsd/RAX-KSADM-credentials.xsd
-keystone/content/common/xsd/RAX-KSADM-users.xsd
-keystone/content/common/xsd/RAX-KSGRP-groups.xsd
-keystone/content/common/xsd/RAX-KSKEY-credentials.xsd
-keystone/content/common/xsd/RAX-KSQA-secretQA.xsd
-keystone/content/common/xsd/roles.xsd
-keystone/content/common/xsd/services.xsd
-keystone/content/common/xsd/tenant.xsd
-keystone/content/common/xsd/to...

Read more...

Changed in keystone:
status: Fix Committed → In Progress
Revision history for this message
Dolph Mathews (dolph) wrote :

The SDX's were intentionally excluded, everything else above should have been included.

https://review.openstack.org/#change,1763

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote :

Reviewed: https://review.openstack.org/1763
Committed: http://github.com/openstack/keystone/commit/253a65bcaf180b4b7a03d3f1fb900fae6e912644
Submitter: Jenkins
Branch: master

 status fixcommitted
 done

commit 253a65bcaf180b4b7a03d3f1fb900fae6e912644
Author: Dolph Mathews <email address hidden>
Date: Fri Nov 18 10:38:09 2011 -0800

    Added wadls, pdfs, samples and functional test confs (bug 891093)

    Change-Id: If8bb42bdbae62e068dd42a2c4d0e4c16b0b41248

Changed in keystone:
status: In Progress → Fix Committed
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to keystone (stable/diablo)

Reviewed: https://review.openstack.org/1761
Committed: http://github.com/openstack/keystone/commit/43a2d7febf072045d1dfaa1199a6e9add58124ba
Submitter: Jenkins
Branch: stable/diablo

 tag in-stable-diablo
 done

commit 43a2d7febf072045d1dfaa1199a6e9add58124ba
Author: Dolph Mathews <email address hidden>
Date: Wed Nov 16 08:30:17 2011 -0800

    pylintrc should not be hidden (bug 891093)

    Change-Id: Ifa7e22b31dd852eecfa3a546fdb8fa30ea96337f

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote :

Reviewed: https://review.openstack.org/1762
Committed: http://github.com/openstack/keystone/commit/ffd1cbf1d10140d52ceac960456bf0aa9f86267c
Submitter: Jenkins
Branch: stable/diablo

 tag in-stable-diablo
 done

commit ffd1cbf1d10140d52ceac960456bf0aa9f86267c
Author: Dolph Mathews <email address hidden>
Date: Wed Nov 16 09:37:26 2011 -0800

    Added files missing from dist packaging (bug 891093)

    - Including wadls, pdfs, samples and functional test confs

    Change-Id: Ic515db5e3392a4eda18d3791fd0e2a6990b42efd

Thierry Carrez (ttx)
Changed in keystone:
milestone: none → essex-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: essex-2 → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.