CodeHosting server should generate OOPSes

Bug #90484 reported by Jonathan Lange
14
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Michael Hudson-Doyle

Bug Description

<ddaa> sftp server oopses is pretty much self-explanatory
<ddaa> I will update the ErrorReportManagementForScript page soon, at kiko's request

Needed for the smart server and perhaps SFTP server if it is still around.

Tags: lp-code
Jonathan Lange (jml)
Changed in launchpad-bazaar:
assignee: nobody → ddaa
importance: Undecided → Medium
status: Unconfirmed → Needs Info
Revision history for this message
Martin Pool (mbp) wrote :

this means getting the sftp server to record errors as oopses?

Revision history for this message
David Allouche (ddaa) wrote :

That's the idea. If anything goes wrong during the life of a session, it should record an oops instead of logging the error in a log file nobody looks at.

An examples of known errors we had were:
 * the xmlrpc client had not been updated, and there was an error at the of the session.
 * the vfs directory observer mechanism was buggy and prevented users to create new directories under .bzr

Both are fixed now, but there might be other problems we are not aware of. Generally, oopses should record two sorts of errors:

 * uncaught exceptions
 * user-visible errors (sftp protocol, or authentication)

We can start with just "uncaught exceptions" and "error reported to the client", and then silence out oopses for errors that are produced as part of the normal operation of bzr dumb client (such as attempting to create already existing hash directories in ./bzr/repo/knits).

If would be nice if the "uncaught exception" reporting could be implemented as a reactor feature so it would be truly global.

Revision history for this message
David Allouche (ddaa) wrote :

Assigning to jml. Do you need more info?

Changed in launchpad-bazaar:
assignee: ddaa → jml
status: Needs Info → Confirmed
Revision history for this message
Jonathan Lange (jml) wrote :

I don't think we should OOPS for all user-visible errors. OOPSing for uncaught exceptions seems fine. Is there a policy on OOPS usage?

I'm pretty sure that Twisted has a handle for uncaught exceptions. At worst, we can hook into the logging system and record an OOPS for any logged errors. I think doing this + tests should constitute fixing this ticket.

Tim Penhey (thumper)
description: updated
Jonathan Lange (jml)
Changed in launchpad-bazaar:
milestone: 1.1.10 → 1.1.11
Revision history for this message
Jonathan Lange (jml) wrote :

I'm not getting this done before I go on leave.

Changed in launchpad-bazaar:
assignee: jml → nobody
Tim Penhey (thumper)
Changed in launchpad-bazaar:
milestone: 1.1.11 → 1.1.12
Changed in launchpad-bazaar:
assignee: nobody → mwhudson
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Well, there's something at bzr+ssh://devpad.canonical.com/code/mwh/launchpad/codehosting-oopses-bug-90484. Comments please.

Changed in launchpad-bazaar:
status: Confirmed → In Progress
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Not going to make 1.1.12 because I haven't figured out how to test it yet.

Changed in launchpad-bazaar:
milestone: 1.1.12 → 1.2.1
Tim Penhey (thumper)
Changed in launchpad-bazaar:
milestone: 1.2.1 → 1.2.2
Revision history for this message
Tim Penhey (thumper) wrote :

Fixed in RF 5639.

Changed in launchpad-bazaar:
status: In Progress → Fix Committed
Tim Penhey (thumper)
Changed in launchpad-bazaar:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.