Mahara

Dwoo_Plugin_theme_{path,url} don't work if plugin location specified

Bug #911683 reported by Iñaki Arenaza
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Iñaki Arenaza
Mahara 1.5.0

Bug Description

Commit 6cf859f817 changed the parameter list of functions theme_url() and theme_path() (in lib/web.php), but it seems Dwoo_Plugin_theme_path() and Dwoo_Plugin_theme_url() weren't modified to use the new parameter list. So they don't work when we specify the plugin location parameter.

This bug applies to 1.4_STABLE and master. I'll send patches to reviews.mahara.org in a few minutes.

Saludos.
Iñaki.

Tags: bitesized
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/967
Committed: http://gitorious.org/mahara/mahara/commit/901b27619f6208f8c9e189c934651dd1fd0793d3
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit 901b27619f6208f8c9e189c934651dd1fd0793d3
Author: I��aki Arenaza <email address hidden>
Date: Sat Dec 31 02:51:32 2011 +0100

    Dwoo_Plugin_theme_{path,url} don't work if plugin location specified (bug #911683)

    Commit 6cf859f817 changed the parameter list of functions theme_url() and
    theme_path() (in lib/web.php), but it seems Dwoo_Plugin_theme_path() and
    Dwoo_Plugin_theme_url() weren't modified to use the new parameter list. So they
    don't work when we specify the plugin location parameter.

    Change-Id: I2993a149e726a6aaf7f1f4a24819a6baff8b7381
    Signed-off-by: I��aki Arenaza <email address hidden>

Richard Mansfield (richard-mansfield)
Changed in mahara:
status: New → In Progress
importance: Undecided → Low
assignee: nobody → Iñaki Arenaza (iarenaza)
Revision history for this message
François Marier (fmarier) wrote :

https://reviews.mahara.org/#change,968

tags: removed: patch
Changed in mahara:
status: In Progress → Fix Committed
milestone: none → 1.5.0
Revision history for this message
Richard Mansfield (richard-mansfield) wrote :

See https://reviews.mahara.org/968 - this fix is going to master only, but leaving the 1.4 patch here in case anyone else needs it.

Revision history for this message
Melissa Draper (melissa) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

status: fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPjqbSAAoJECXBtiziiXdc9lQH/ihyu7QAsQTauz6R0kgBF2og
xGfwoCzflrqvhr0M52SR9mS/oVvb0ZerWl6CL2aJ8Aq5dTGNZ2+dHsDZTTYGQzF0
qLheaMcgjVQyCasJQzFwP4eVhxP5d7PUvHTPoB2SfQOMrzb6LdbF3ZuaPk11bImk
zjRhyzLIDuqPGCvkm/RSr3RlyuLlQD6/mSXfHLXRMKuG6ZXZQdgwvAgbRVrqCukJ
HeAfb9i1gVLgMoKO1OGur+sCYD155g6GtykNolwC1vXGI2lwL5yko4rBq47m1zTJ
iEMJngvutbkLqfkLye2DrqEGfPdJSD28cn0yTrGo4r8c8v+VErQG2fw28Do62AQ=
=PEOy
-----END PGP SIGNATURE-----

Revision history for this message
Melissa Draper (melissa) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPjrKtAAoJECXBtiziiXdcUwoH/2T7TneDztExyzwY3jqJTs/Y
RyZ+uApeCE5D2ICXyJjXwQa5J4hwSnVwXWB6W0BGUspaTlHk5DU2uHMV7tJ6GnyK
+Z/jxi99+oRi3ejXk21hpZou9c1uPTtHHzNw8l/y8S3yOBwo+kWE9UNjrpYHNGZc
BRtQyh447e+4x4ocrR5ldieyEo5gYiFztVAtxNKSx00iCTpGXEiGmLKQ+8RhABMc
b/yOYWmLrgcBrvbC8xuQWZoXYgiZvsC0pjZnMHVW1SDrXHLbxsdcE1D/T1Vm+U7q
f0tHry8pHQnJQlbd8hm6vlOQR8Zo3wEB8knRCR0euQFr9oC32PBHaVLHZ75Dx+4=
=NY/1
-----END PGP SIGNATURE-----

Revision history for this message
Melissa Draper (melissa) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPjrT9AAoJECXBtiziiXdcoRgIAI6WEF/A3ND2GQDSpnq5f/tC
dX+/FeJZVxYHJpRv9z3v9pQ47AuNacrcWJkRdDsc7A+/XEP++DWUU5lvYy65941s
gekqH765BpnPqOU3QAWzhhQqQAJo/aSk94H+YZCoJTtw4tA4sOWxITkItb1SAt33
Q8bnKihJZYHtgfKtEv7gzd2oyk5Jk1xAJjE8fpcJpjXdkpF2Gda82JOpR2hrFnfo
k/nH5VLwHELKBMmLhFjTasfe2R5/LjBaDQp4r93ZdZBl5qer00yUQoEIgInJg+LK
Rs5onHkg5YWn5ezTrMkRBAp/goHyrcYaunC4sJ4cazP1+YtC10oJq8fnuv1Xq9A=
=fz6e
-----END PGP SIGNATURE-----

Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.