Glance

Glance unittests that setup the FAKE_FILESYSTEM_ROOTDIR should use a unique testing directory per test case

Bug #913608 reported by Jay Pipes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Medium
Jay Pipes
Glance 2012.1 "essex"

Bug Description

In order to enable parallel execution as well as overcome some odd fsync() timing issues that sometimes pop up, the call to glance.tests.stubs.stubout_fake_filesystem() should use a unique directory for each test.

Jay Pipes (jaypipes)
Changed in glance:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/2945

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/2945
Committed: http://github.com/openstack/glance/commit/b4624ec24240c1c15d4daed07afd19eb21474be4
Submitter: Jenkins
Branch: master

commit b4624ec24240c1c15d4daed07afd19eb21474be4
Author: Jay Pipes <email address hidden>
Date: Tue Jan 10 17:49:42 2012 -0500

    Fixes LP Bug#913608 - tests should be isolated

    This reworks the stubs.FAKE_FILESYSTEM_ROOTDIR used in unit
    tests by making each test case create and destroy its own little
    sandbox in /tmp/test.*/images. Adds a base IsolatedUnitTest that
    tests needing to have an isolated filesystem_store_datadir and
    configuration can inherit from.

    Change-Id: I396f5127c6a687da8dcef3368e7ed0912efc9b3a

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: essex-3 → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.