remove automatic comment text from reviews
Bug #914431 reported by
Monty Taylor
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Core Infrastructure |
Expired
|
Low
|
Unassigned |
Bug Description
It has been requested that voting on a review does not produce the automatic comments, such as "I would prefer you didn't submit this" and that the review comment box be made mandatory.
Changed in openstack-ci: | |
importance: | Undecided → Low |
status: | New → Triaged |
tags: | added: gerrit |
To post a comment you must log in.
Those serve an important function in that they record the voting history for a review
without them, you would not be able to see that someone had, say, voted -1, then voted +2 later.
However, the text is easily configurable. Current values:
name | category_id | value ------- ------- ------- ------- ------- ------- +------ ------- +------
------
Verified | VRIF | 1
No score | VRIF | 0
Fails | VRIF | -1
Looks good to me (core reviewer) | CRVW | 2
Looks good to me, but someone else must approve | CRVW | 1
No score | CRVW | 0
I would prefer that you didn't submit this | CRVW | -1
Do not submit | CRVW | -2
No score | APRV | 0
Approved | APRV | 1