neutron

quantum tarball missing files, including OVS agent

Bug #925074 reported by Robert Kukura
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Critical
Robert Kukura
neutron 2012.1 "essex"
quantum (Ubuntu)
Fix Released
Undecided
Unassigned
Nominated for Precise by Yolanda Robla

Bug Description

The quantum-2012.1~e3.tar.gz tarball is missing a number of files that are present in git and that may be needed by packagers and/or end users:

LICENSE
quantum/plugins/cisco/README
quantum/plugins/cisco/services/README
quantum/plugins/openvswitch/agent (and its contents)
quantum/plugins/openvswitch/README

Also, if they aren't completely deprecated, the following may be useful to packagers that want to provide separately installable packages for the server and each plugin rather than a monolithic package:

setup_cisco_plugin.py
setup_openvswitch_plugin.py
setup_sample_plugin.py
setup_server.py

If any of these files are completely obsolete, they should be removed from git as well.

Robert Kukura (rkukura)
summary: - quantum tarball missing files
+ quantum tarball missing files, including OVS agent
Revision history for this message
dan wendlandt (danwent) wrote :

Sorry Robert, missed this in a flood of email.

As a packager, is it your opinion that we should release a new essex-3.1 tarball that includes the proper files? It seems like otherwise we are making life even harder on those packaging.

I'll leave brad to comment on the setup_* files. I believe we were leaving them there as a hint to packagers, but that concerns me as I don't want the files to become stale/incorrect over time. What do you think is the best way to give packagers these type of suggestions on how to package? Thanks.

Changed in quantum:
milestone: none → essex-4
importance: Undecided → High
importance: High → Critical
status: New → Confirmed
assignee: nobody → Brad Hall (bgh)
Revision history for this message
Robert Kukura (rkukura) wrote :

Dan,

We can temporarily work around this by adding the missing files to fedora's git repository. Or we can just leave them out until we package E4 (we need to finish packaging the OVS userspace tools for the agent to be useful). So I wouldn't bother with a 3.1 just to resolve this bug for us. We've also had to work around the missing __init__.py from quantumclient, and the duplicate quantum CLI console scripts bugs. If we did do a 3.1, it would be nice to fix these as well, and we'd probably update our packaging. But this can all easily wait for E4.

Not sure about the setup_*.py files. As of right now, we're just producing openstack-quantum and python-quantumclient packages, not separate packages for each plugin. These things are small, so the main reason to break plugins out would be so they could each pull in their own runtime dependencies. For example, we'd have our openstack-quantum-ovs-agent package depend on the OVS user-space tools package. But I haven't seen nova trying to break out different hypervisor drivers, so maybe we shouldn't bother either. Looking for other opinions here.

-Bob

Revision history for this message
Ghe Rivero (ghe.rivero) wrote :

Hi,
    in the case of Debian, there is no need for a 3.1 release, since we get the sources using the tags from the git repositories. And about setup_*.py files, we have split into 5 packages, but we use the main setup.py so there is no need to keep them.

Revision history for this message
Brad Hall (bgh) wrote :

OK, if we don't need them then I'm glad to remove them. Thanks for the comments.

Robert Kukura (rkukura)
Changed in quantum:
assignee: Brad Hall (bgh) → Robert Kukura (rkukura)
Revision history for this message
Robert Kukura (rkukura) wrote :

There was agreement at the netstack meeting yesterday to drop the setup_*.py files, so I'll take care of this as well.

Changed in quantum:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/4286

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/4286
Committed: http://github.com/openstack/quantum/commit/d6bf2b76162ba806b2ad1f636f6273e47e03a117
Submitter: Jenkins
Branch: master

commit d6bf2b76162ba806b2ad1f636f6273e47e03a117
Author: Bob Kukura <email address hidden>
Date: Fri Feb 17 17:00:52 2012 -0500

    Cleanup the source distribution.

    Missing text files such as LICENSE and various READMEs are now
    included in the tarball source distribution. The Makefile and shell
    script for installing the openvswitch agent on xen are also now
    included. The openvswitch and linuxbridge agents are included, and
    executable wrapper scripts for the agents are provided. The cisco and
    linuxbridge nova drivers are now setup to be run from the quantum
    namespace rather than copied to nova. Finally, the setup_*.py scripts
    have been removed from the project. Fixes bug 925074.

    Test by running "python setup.py sdist" and examining the generated
    tarball.

    Change-Id: I33d336a5eb13678e6d527b575958393b337b6f3d
    Signed-off-by: Bob Kukura <email address hidden>

Changed in quantum:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in quantum:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: essex-4 → 2012.1
Yolanda Robla (yolanda.robla)
Changed in quantum (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.