OpenStack Compute (nova)

nova-rootwrap does not wait() for subprocess before returning

Bug #928566 reported by Adam Gandelman on 2012-02-07

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Compute (nova)	Fix Released	Undecided	Adam Gandelman	OpenStack Compute (nova) 2012.1 "essex"

Bug Description

nova-rootwrap does not wait() for the subprocess it executes to complete before returning its return code. This often ends up in 0 being returned regardless of failure/success and causing unforeseen problems in nova (see Bug #922232 )

:~# sudo nova-rootwrap false ; echo $?
0

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2012-02-07: Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/3875

Changed in nova:
assignee:	nobody → Adam Gandelman (gandelman-a)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2012-02-08: Fix merged to nova (master)

Reviewed: https://review.openstack.org/3875
Committed: http://github.com/openstack/nova/commit/40206cb80a8a1636eac0733360a0cc67bea9a6da
Submitter: Jenkins
Branch: master

commit 40206cb80a8a1636eac0733360a0cc67bea9a6da
Author: Adam Gandelman <email address hidden>
Date: Tue Feb 7 15:57:38 2012 -0800

nova-rootwrap: wait() for return code before exit

    nova-rootwrap does not wait() for the subprocess it executes to complete before
    returning its return code. This often ends up in 0 being returned regardless of
    failure/success and causing unforeseen problems in Nova.

Fixes bug #928566

Change-Id: I9b6d85c747513086d0e774cb92ba403886b3283c