Ubuntu
xsettings-kde package

[MIR] xsettings-kde

Bug #930384 reported by Philip Muškovac
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
xsettings-kde (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

xsettings-kde will be used to set the default GTK3 theme in Kubuntu Precise so it needs to be in main.
There are no open bugs about the package in ubuntu and debian.
Q/A was done by the Kubuntu team.
It has no UI.
packaging meets the MIR requirements.
No CVEs

Revision history for this message
Michael Terry (mterry) wrote :

This is mostly fine. Simple enough program, simple packaging, not fast moving. Does anyone know what the story is with Debian on this package?

It does use sprintf unsafely a few places, but always when reading from a 'trusted' location like /etc/kderc. So doesn't seem like a reasonable attack vector.

There is one low-quality red flag that I want to block on though: kubuntu_gtktheme.patch introduces a compile warning that seems a genuine problem:

xsettings-kde.c:443:11: warning: ‘password’ may be used uninitialized in this function [-Wuninitialized]

Seems like the patch just needs to add a '= NULL" to the declaration of password.

Changed in xsettings-kde (Ubuntu):
status: New → Incomplete
Revision history for this message
Philip Muškovac (yofel) wrote :

I fixed the pointer which indeed should be initialized with NULL when used in this way in ubuntu2.
As for the debian history, the only existing one I could find is the ITP: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=512562

Changed in xsettings-kde (Ubuntu):
status: Incomplete → New
Michael Terry (mterry)
Changed in xsettings-kde (Ubuntu):
status: New → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote :

Promoted.

Changed in xsettings-kde (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.