Unpythonic code in redux in auth_token.py

Bug #932578 reported by Yaroslav
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Undecided
Zhongyue Luo

Bug Description

Hello! I found some unpythonic and un-optimal code in auth_token.py, so I clean it and here is a patch

There are also other places of the code which are not pythonic and not pep8 standard.

Tags: redux
Revision history for this message
Yaroslav (yaroslav-isakov) wrote :
Revision history for this message
Zhongyue Luo (zyluo) wrote :

I saw your patch and the code you mentioned is located in quantum_auth_token.py

I'll do a clean-up of this module and send a commit proposal.

Changed in keystone:
assignee: nobody → Zhongyue Luo (lzyeval)
description: updated
summary: - Unpythonic code in redux in auth_token.py
+ Unpythonic code in redux in quantum_auth_token.py
Revision history for this message
Zhongyue Luo (zyluo) wrote :

I'm sorry, I thought I checked out to redux but was still in master. I'll do a whole cleanup of the module.

summary: - Unpythonic code in redux in quantum_auth_token.py
+ Unpythonic code in redux in auth_token.py
description: updated
tags: added: redux
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/4385

Changed in keystone:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/4385
Committed: http://github.com/openstack/keystone/commit/834b931cba15e7ded27555c0f9c1ea0e2eb99f56
Submitter: Jenkins
Branch: master

commit 834b931cba15e7ded27555c0f9c1ea0e2eb99f56
Author: Zhongyue Luo <email address hidden>
Date: Wed Feb 22 13:41:13 2012 +0800

    Unpythonic code in redux in auth_token.py

    Fixed bug #932578

    Fixes code which are not pythonic and not pep8 standard.

    Change-Id: Idd8ba4a75ad0a854a60238aec2d8d32ff2ee9c53

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
milestone: none → essex-4
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: essex-4 → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.