test cases "test_list_flavors_detailed_filter_by_min_disk" and "test_list_flavors_filter_by_min_disk" only work if "flavor_ref" set to the minimum flavor

Bug #932859 reported by Christian Berendt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tempest
Fix Released
Medium
Daryl Walleck

Bug Description

my flavor list:

+----+-----------+-----------+------+----------+-------+-------------+
| ID | Name | Memory_MB | Swap | Local_GB | VCPUs | RXTX_Factor |
+----+-----------+-----------+------+----------+-------+-------------+
| 2 | m1.small | 2048 | | 10 | 1 | 1.0 |
| 3 | m1.medium | 4096 | | 10 | 2 | 1.0 |
| 4 | m1.large | 8192 | | 10 | 4 | 1.0 |
| 5 | m1.xlarge | 16384 | | 10 | 8 | 1.0 |
| 6 | testing | 512 | | 0 | 1 | 1.0 |
+----+-----------+-----------+------+----------+-------+-------------+

i set flavor_ref=6 in etc/tempest.conf, test cases are working fine:

The list of flavors should be filtered by disk space ... ok
The list of flavors should be filtered by RAM ... ok

now i remove the flavor with id 6 and i set flavor_ref=2 in etc/tempest.conf, test cases are now failing:

+----+-----------+-----------+------+----------+-------+-------------+
| ID | Name | Memory_MB | Swap | Local_GB | VCPUs | RXTX_Factor |
+----+-----------+-----------+------+----------+-------+-------------+
| 2 | m1.small | 2048 | | 10 | 1 | 1.0 |
| 3 | m1.medium | 4096 | | 10 | 2 | 1.0 |
| 4 | m1.large | 8192 | | 10 | 4 | 1.0 |
| 5 | m1.xlarge | 16384 | | 10 | 8 | 1.0 |
+----+-----------+-----------+------+----------+-------+-------------+

======================================================================
FAIL: The detailed list of flavors should be filtered by disk space
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/berendt/Documents/repositories/tempest/tempest/tests/test_flavors.py", line 97, in test_list_flavors_detailed_filter_by_min_disk
    self.assertFalse(any([i for i in flavors if i['id'] == flavor_id]))
AssertionError: True is not False

======================================================================
FAIL: The list of flavors should be filtered by disk space
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/berendt/Documents/repositories/tempest/tempest/tests/test_flavors.py", line 121, in test_list_flavors_filter_by_min_disk
    self.assertFalse(any([i for i in flavors if i['id'] == flavor_id]))
AssertionError: True is not False

----------------------------------------------------------------------
Ran 13 tests in 2.614s

FAILED (failures=2)

Revision history for this message
Christian Berendt (berendt) wrote :

after re-adding the smallest flavor the test cases are working fine...

+----+------------+-----------+------+----------+-------+-------------+
| ID | Name | Memory_MB | Swap | Local_GB | VCPUs | RXTX_Factor |
+----+------------+-----------+------+----------+-------+-------------+
| 2 | m1.small | 2048 | | 10 | 1 | 1.0 |
| 3 | m1.medium | 4096 | | 10 | 2 | 1.0 |
| 4 | m1.large | 8192 | | 10 | 4 | 1.0 |
| 5 | m1.xlarge | 16384 | | 10 | 8 | 1.0 |
| 6 | testing001 | 512 | | 0 | 1 | 1.0 |
+----+------------+-----------+------+----------+-------+-------------+

The list of flavors should be filtered by disk space ... ok
The list of flavors should be filtered by RAM ... ok

Revision history for this message
David Kranz (david-kranz) wrote :

I saw the same error when running tempest against diablo. I assumed it was a diablo bug that was fixed in essex. I changed the test to skip on diablo but perhaps it is a real essex nova bug that is triggered by the old diablo flavor list but not the new essex one.

Revision history for this message
Christian Berendt (berendt) wrote :

tested against a fresh devstack environment with git checkout from today.

Revision history for this message
Jay Pipes (jaypipes) wrote :

I also see this on diablo/stable.

tags: added: diablo
Changed in tempest:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Jay Pipes (jaypipes)
Revision history for this message
Jay Pipes (jaypipes) wrote :

OK, so it turns out that no query parameters or filters are supported in the flavor listing in Diablo. So, for the stable/diablo branch, the solution is removal of the test cases from the flavor tests

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tempest (stable/diablo)

Fix proposed to branch: stable/diablo
Review: https://review.openstack.org/4722

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tempest (stable/diablo)

Reviewed: https://review.openstack.org/4722
Committed: http://github.com/openstack/tempest/commit/27df692700cb7c69a67f83cdbe82578cbc1b7c3f
Submitter: Jenkins
Branch: stable/diablo

commit 27df692700cb7c69a67f83cdbe82578cbc1b7c3f
Author: Jay Pipes <email address hidden>
Date: Wed Feb 29 16:31:35 2012 -0500

    Fixes LP #932859 for stable/diablo

    * No query params or filters are supported in the Diablo
      flavors listing calls, so this patch removes the unsupported
      test cases

    Change-Id: Ibd40185203c004aeb2ca398822bae247d3cc187b

tags: added: in-stable-diablo
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tempest (master)

Fix proposed to branch: master
Review: https://review.openstack.org/5360

Changed in tempest:
assignee: Jay Pipes (jaypipes) → Donald Ngo (donald-ngo)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/6260

Changed in tempest:
assignee: Donald Ngo (donald-ngo) → Daryl Walleck (dwalleck)
Revision history for this message
Attila Fazekas (afazekas) wrote :

As I remember it is fixed.

Jay Pipes (jaypipes)
Changed in tempest:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.