security_group name is an XML element when creating a server, an attribute everywhere else
Bug #933785 reported by
justinsb
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenStack Compute (nova) |
Fix Released
|
Undecided
|
justinsb | ||
Bug Description
When creating a server, the security group names must be specified as an element. Everywhere else, the name is an attribute. This is painful.
I'm proposing a fix that checks for an attribute first on server create, but then falls back to an element so any XML clients will continue to work. Eventually I think we'll want to deprecate the element fallback.
I've already written and proposed the patch, but I wanted to link it to a bug report:
https:/
| Changed in nova: | |
| status: | New → In Progress |
| Changed in nova: | |
| assignee: | nobody → justinsb (justin-fathomdb) |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix merged to nova (master) | #1 |
| Changed in nova: | |
| status: | In Progress → Fix Committed |
| Changed in nova: | |
| milestone: | none → essex-4 |
| status: | Fix Committed → Fix Released |
| Changed in nova: | |
| milestone: | essex-4 → 2012.1 |
To post a comment you must log in.
Reviewed: https:/
Committed: http://
Submitter: Jenkins
Branch: master
commit 6a951c77adf6d51
Author: Justin Santa Barbara <email address hidden>
Date: Thu Feb 16 00:13:41 2012 -0800
The security_group name should be an XML attribute
It is everywhere apart from in servers.py. We have to be backwards
compatible, so we check the attribute first, and then check the element.
Bug #933785
Change-Id: I66b96376043e66