gdpbzr error opening diverged from when there is no parent

Bug #935421 reported by Curtis Hovey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Gedit Developer Plugins
Fix Released
Medium
Curtis Hovey
gedit-developer-plugins (Ubuntu)
Fix Released
Undecided
Curtis Hovey

Bug Description

I saw the following error when I accidentally tried to open diverged files. I know my branch is the master and without a parent. This same issue can happen to open unpushed files if there is not a push location set. There are two way of dealing with this. The simplest is to catch the NotBranchError error and explain there is no parent or push location. Maybe the menu item could be disabled when the option is not available. I doubt this can be done as the traceback shows, bzrlib assumed the repo was the parent branch so the UI thinks there is parent too.

  File "/home/curtis/.local/share/gedit/plugins/gdp/bzr.py", line 130, in open_changed_files_from_parent
    self.open_changed_files(self._parent_tree)
  File "/home/curtis/.local/share/gedit/plugins/gdp/bzr.py", line 94, in _parent_tree
    self.working_tree.branch.get_parent())
  File "/home/curtis/.local/share/gedit/plugins/gdp/bzr.py", line 82, in _get_branch_revision_tree
    return revision.as_tree(self.working_tree.branch)
  File "/usr/lib/python2.7/dist-packages/bzrlib/revisionspec.py", line 268, in as_tree
    return self._as_tree(context_branch)
...
  File "/usr/lib/python2.7/dist-packages/bzrlib/controldir.py", line 1139, in find_format
    raise errors.NotBranchError(path=transport.base)
bzrlib.errors.NotBranchError: Not a branch: "/home/curtis/Hacking/trunk/".

Tags: bzr gdpbzr oops

Related branches

Curtis Hovey (sinzui)
tags: added: oops
Changed in gdp:
status: Triaged → In Progress
Curtis Hovey (sinzui)
Changed in gdp:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
Changed in gdp:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
Changed in gedit-developer-plugins (Ubuntu):
assignee: nobody → Curtis Hovey (sinzui)
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gedit-developer-plugins - 0.5.13-0ubuntu1

---------------
gedit-developer-plugins (0.5.13-0ubuntu1) precise; urgency=low

  * New upstream bug-fix release
    - Error: Gtk.Justification. does not complete (LP: #932086)
    - gdpfind's theads to not play with gtk's threads (LP:# 934643)
    - gdpformat syntax checking can block the use of gedit (LP: #934653)
    - gdpbzr error opening diverged from when there is no parent (LP: #935421)
    - doctest reformatter replaces the text with the filename (LP: #944954)
    - Pressing enter in the "Look in" entry does not start find (LP: #951900)
 -- <email address hidden> (Curtis C. Hovey) Mon, 12 Mar 2012 09:04:13 -0400

Changed in gedit-developer-plugins (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.